Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure high code coverage (now: 77.25%) #36

Closed
aik099 opened this issue Dec 4, 2013 · 3 comments
Closed

Ensure high code coverage (now: 77.25%) #36

aik099 opened this issue Dec 4, 2013 · 3 comments

Comments

@aik099
Copy link
Member

aik099 commented Dec 4, 2013

Main issue: https://github.com/Behat/Mink/issues/406

Code Coverage: 77.25%
browserkit_code_coverage

@stof
Copy link
Member

stof commented Jan 30, 2014

the coverage was increased a bit (approx 85% IIRC), and then #46 made it drop again as the test does not run through the code converting HttpFoundation responses to BrowserKit ones (which becomes a BC layer only). Running the tests on Symfony 2.2 would report a higher code coverage than on 2.3+ because of this.
Thanks to the removal of the BC layers in #44 for the 2.x branch, the coverage reaches 91%. Most of the remaining uncovered cases are actually safeguards throwing an error for invalid usage (some of them are probably hard to reach when using the driver through the higher level API of the element IMO)

@stof
Copy link
Member

stof commented May 2, 2014

sorry, I wanted to close the GoutteDriver issue

@stof
Copy link
Member

stof commented May 2, 2014

We now have 82% coverage, and 97% in the PR for 2.0 after removing the support of legacy Symfony versions. Closing this issue

@stof stof closed this as completed May 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants