Merge pull request #184 from stof/fix_phpstan

Fix phpstan job
minkphp · Jan 9, 2025 · 924553d · 924553d
2 parents 207f8a5 + 32dbd12
commit 924553d
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 4 deletions.
diff --git a/phpstan.dist.neon b/phpstan.dist.neon
@@ -3,8 +3,8 @@ parameters:
     paths:
         - src
         - tests
-    checkMissingIterableValueType: false
     ignoreErrors:
+        - identifier: missingType.iterableValue # TODO remove this ignore rule once DriverInterface defines the appropriate value types
         - '#^Method Behat\\Mink\\Tests\\Driver\\Custom\\[^:]+Test(Case)?\:\:test\w*\(\) has no return type specified\.$#'
 
 includes:

diff --git a/src/BrowserKitDriver.php b/src/BrowserKitDriver.php
@@ -28,11 +28,14 @@
  * Symfony BrowserKit driver.
  *
  * @author Konstantin Kudryashov <[email protected]>
+ *
+ * @template TRequest of object
+ * @template TResponse of object
  */
 class BrowserKitDriver extends CoreDriver
 {
     /**
-     * @var AbstractBrowser
+     * @var AbstractBrowser<TRequest, TResponse>
      */
     private $client;
 
@@ -52,7 +55,8 @@ class BrowserKitDriver extends CoreDriver
     /**
      * Initializes BrowserKit driver.
      *
-     * @param string|null $baseUrl Base URL for HttpKernel clients
+     * @param AbstractBrowser<TRequest, TResponse> $client
+     * @param string|null                          $baseUrl Base URL for HttpKernel clients
      */
     public function __construct(AbstractBrowser $client, ?string $baseUrl = null)
     {
@@ -71,7 +75,7 @@ public function __construct(AbstractBrowser $client, ?string $baseUrl = null)
     /**
      * Returns BrowserKit browser instance.
      *
-     * @return AbstractBrowser
+     * @return AbstractBrowser<TRequest, TResponse>
      */
     public function getClient()
     {

diff --git a/tests/Custom/ErrorHandlingTest.php b/tests/Custom/ErrorHandlingTest.php
@@ -154,12 +154,18 @@ public function testClickOnUnsupportedElement()
         $driver->click('//div');
     }
 
+    /**
+     * @return BrowserKitDriver<object, Response>
+     */
     private function getDriver(): BrowserKitDriver
     {
         return new BrowserKitDriver($this->client);
     }
 }
 
+/**
+ * @template-extends AbstractBrowser<object, Response>
+ */
 class TestClient extends AbstractBrowser
 {
     /**