sw-7186 increase window size and remove hard coded heights that throw… (

#473) * sw-7186 increase window size and remove hard coded heights that throw console errors * sw-7186 set to 500px for test * Update main.scss
ministryofjustice · Jul 4, 2024 · 5d8d713 · 5d8d713
1 parent 58ecac5
commit 5d8d713
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 9 deletions.
diff --git a/web/assets/main.scss b/web/assets/main.scss
@@ -36,3 +36,7 @@ $moj-assets-path: "/supervision/workflow/assets/";
   color: govuk-colour("blue");
   text-decoration: underline;
 }
+
+#list-of-tasks-to-filter{
+    max-height: 500px;
+}
diff --git a/web/template/filters/assignee-filter.gotmpl b/web/template/filters/assignee-filter.gotmpl
@@ -15,7 +15,7 @@
         </div>
       </div>
 
-      <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-assignees-to-filter" tabindex="-1" style="height: 254.333px;">
+      <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-assignees-to-filter" tabindex="-1">
         <div class="app-c-option-select__container-inner js-auto-height-inner">
           <fieldset class="govuk-fieldset" aria-label="Assigned">
             <legend class="hide">Assignees</legend>

diff --git a/web/template/filters/case-type-filter.gotmpl b/web/template/filters/case-type-filter.gotmpl
@@ -18,7 +18,7 @@
       </div>
     </div>
 
-    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-case-types-to-filter" tabindex="-1" style="height: 254.333px;">
+    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-case-types-to-filter" tabindex="-1">
       <div class="app-c-option-select__container-inner js-auto-height-inner ">
         <fieldset class="govuk-fieldset" aria-label="Case type">
           <legend class="hide" >Case type</legend>

diff --git a/web/template/filters/deputy-type-filter.gotmpl b/web/template/filters/deputy-type-filter.gotmpl
@@ -18,7 +18,7 @@
       </div>
     </div>
 
-    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-deputy-types-to-filter" tabindex="-1" style="height: 254.333px;">
+    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-deputy-types-to-filter" tabindex="-1">
       <div class="app-c-option-select__container-inner js-auto-height-inner ">
         <fieldset class="govuk-fieldset" aria-label="Deputy type">
           <legend class="hide" >Deputy type</legend>

diff --git a/web/template/filters/ecm-filter.gotmpl b/web/template/filters/ecm-filter.gotmpl
@@ -14,7 +14,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-ecms-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-ecms-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner">
       <fieldset class="govuk-fieldset" aria-label="Assigned">
         <legend class="hide">Executive Case Managers</legend>

diff --git a/web/template/filters/status-filter.gotmpl b/web/template/filters/status-filter.gotmpl
@@ -15,7 +15,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-statuses-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-statuses-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner ">
       <fieldset class="govuk-fieldset" aria-label="Status">
         <legend class="hide" >Status</legend>

diff --git a/web/template/filters/supervision-level-filter.gotmpl b/web/template/filters/supervision-level-filter.gotmpl
@@ -20,7 +20,7 @@
           </div>
         </div>
 
-        <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-supervision-levels-to-filter" tabindex="-1" style="height: 254.333px;">
+        <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-supervision-levels-to-filter" tabindex="-1">
           <div class="app-c-option-select__container-inner js-auto-height-inner ">
             <fieldset class="govuk-fieldset" aria-label="Supervision level">
               <legend class="hide" >Supervision level</legend>

diff --git a/web/template/filters/task-type-filter.gotmpl b/web/template/filters/task-type-filter.gotmpl
@@ -1,7 +1,7 @@
 {{- /*gotype: github.com/ministryofjustice/opg-sirius-workflow/internal/server.FilterByTaskType*/ -}}
 {{ define "task-type-filter" }}
 
-<div class="moj-filter__options" data-filter-name="moj-filter-name-tasktype">
+<div class="moj-filter__options" data-filter-name="moj-filter-name-tasktype" id="moj-filter-name-tasktype">
 
   <div class="app-c-option-select">
     <div class="app-c-option-select__heading js-container-heading filter-toggle-button">
@@ -15,7 +15,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-tasks-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-tasks-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner ">
       <fieldset class="govuk-fieldset" aria-label="Task type">
         <legend class="hide" >Task types</legend>

diff --git a/web/template/inserts/success-banner.gotmpl b/web/template/inserts/success-banner.gotmpl
@@ -1,6 +1,6 @@
 {{ define "success-banner" }}
   <div class="moj-banner moj-banner--success" data-module="moj-banner-auto-hide">
-    <svg class="moj-banner__icon" fill="currentColor" role="presentation" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 25 25" height="25" width="25">
+    <svg class="moj-banner__icon" fill="currentColor" role="presentation" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 25 25" width="25">
       <path d="M25,6.2L8.7,23.2L0,14.1l4-4.2l4.7,4.9L21,2L25,6.2z" />
     </svg>