Fix lint errors in datepicker and refactor setExcludedDates method #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to appease eslint The large map function in the setExcldedDates method was hard to read, and eslint didn't like it didn't have an obvious return value. This commit refactors part of the map into a parseDateRangeString function making the code much more readable and control flow more obvious.
chrispymm
force-pushed
the
js-lint-datepicker
branch
from
39b023b to
26c145b
Compare
jbarnardmoj
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all linting errors for the datepicker component.
Refactors the
setExludedDatesmethod to both fix linting errors and increase readability.