Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PagerDuty integration keys in AWS Secrets Manager configuration #9117

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

matt-heery
Copy link
Contributor

A reference to the issue / Description of it

Forgot to add the secret to the service

How does this PR fix the problem?

Adds an emd secret

Deployment Plan / Instructions

n/a

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

@matt-heery matt-heery requested a review from a team as a code owner January 29, 2025 13:12
@matt-heery matt-heery enabled auto-merge January 29, 2025 13:12
Copy link
Contributor

Terraform Plan Summary

pagerduty
Plan: 1 to add, 0 to change, 1 to destroy.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/pagerduty


Running Trivy in terraform/pagerduty
2025-01-29T13:14:14Z INFO [vulndb] Need to update DB
2025-01-29T13:14:14Z INFO [vulndb] Downloading vulnerability DB...
2025-01-29T13:14:14Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-29T13:14:16Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-29T13:14:16Z INFO [vuln] Vulnerability scanning is enabled
2025-01-29T13:14:16Z INFO [misconfig] Misconfiguration scanning is enabled
2025-01-29T13:14:16Z INFO [misconfig] Need to update the built-in checks
2025-01-29T13:14:16Z INFO [misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-29T13:14:16Z INFO [secret] Secret scanning is enabled
2025-01-29T13:14:16Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-29T13:14:16Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-29T13:14:17Z INFO [terraform scanner] Scanning root module file_path="."
2025-01-29T13:14:17Z WARN [terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly. module="root" variables="pagerduty_token, pagerduty_user_token"
2025-01-29T13:14:17Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2025-01-29T13:14:17Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_event_orchestration_service.az_dso_alerts" value="cty.NilVal"
2025-01-29T13:14:17Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="pagerduty_service_integration.az_dso_alerts" value="cty.NilVal"
2025-01-29T13:14:17Z INFO Number of language-specific files num=0
2025-01-29T13:14:17Z INFO Detected config files num=1
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/pagerduty

*****************************

Running Checkov in terraform/pagerduty
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
terraform scan results:

Passed checks: 28, Failed checks: 0, Skipped checks: 10


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/pagerduty

*****************************

Running tflint in terraform/pagerduty
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/pagerduty

*****************************

Running Trivy in terraform/pagerduty
2025-01-29T13:14:14Z	INFO	[vulndb] Need to update DB
2025-01-29T13:14:14Z	INFO	[vulndb] Downloading vulnerability DB...
2025-01-29T13:14:14Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-29T13:14:16Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-29T13:14:16Z	INFO	[vuln] Vulnerability scanning is enabled
2025-01-29T13:14:16Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-01-29T13:14:16Z	INFO	[misconfig] Need to update the built-in checks
2025-01-29T13:14:16Z	INFO	[misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [------------------------------------------------------] 100.00% ? p/s 100ms2025-01-29T13:14:16Z	INFO	[secret] Secret scanning is enabled
2025-01-29T13:14:16Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-29T13:14:16Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-29T13:14:17Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-01-29T13:14:17Z	WARN	[terraform parser] Variable values was not found in the environment or variable files. Evaluating may not work correctly.	module="root" variables="pagerduty_token, pagerduty_user_token"
2025-01-29T13:14:17Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_team_membership.modernisation_platform_membership" value="cty.NilVal"
2025-01-29T13:14:17Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_event_orchestration_service.az_dso_alerts" value="cty.NilVal"
2025-01-29T13:14:17Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="pagerduty_service_integration.az_dso_alerts" value="cty.NilVal"
2025-01-29T13:14:17Z	INFO	Number of language-specific files	num=0
2025-01-29T13:14:17Z	INFO	Detected config files	num=1
trivy_exitcode=0

@matt-heery matt-heery added this pull request to the merge queue Jan 29, 2025
Merged via the queue into main with commit ad66aa6 Jan 29, 2025
6 checks passed
@matt-heery matt-heery deleted the em/add-pager-duty-secret branch January 29, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants