Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/8695 - DO NOT MERGE #9084

Closed
wants to merge 19 commits into from
Closed

Issue/8695 - DO NOT MERGE #9084

wants to merge 19 commits into from

Conversation

mikereiddigital
Copy link
Contributor

A reference to the issue / Description of it

{Please write here}

How does this PR fix the problem?

{Please write here}

How has this been tested?

Please describe the tests that you ran and provide instructions to reproduce.

{Please write here}

Deployment Plan / Instructions

Will this deployment impact the platform and / or services on it?

{Please write here}

Checklist (check x in [ ] of list items)

  • I have performed a self-review of my own code
  • All checks have passed
  • I have made corresponding changes to the documentation
  • Plan and discussed how it should be deployed to PROD (If needed)

Additional comments (if any)

{Please write here}

@mikereiddigital mikereiddigital requested a review from a team as a code owner January 27, 2025 08:59
Copy link
Contributor

Terraform Plan Summary

single-sign-on
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected a number of resources are to be deleted. Please review the plan and confirm the changes are expected.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning - Large Number of Resources to be Destroyed.

core-vpc-preproduction
Plan: 0 to add, 0 to change, 9 to destroy.
Please review the plan and confirm the changes are expected.

Copy link
Contributor

Terraform Plan Summary

core-vpc-preproduction
Plan: 0 to add, 0 to change, 9 to destroy.

Copy link
Contributor

Terraform Plan Summary

modernisation-platform-account
Plan: 0 to add, 3 to change, 0 to destroy.

Copy link
Contributor

Terraform Plan Summary

core-vpc-production
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

Terraform Plan Summary

pagerduty
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected a number of resources are to be deleted. Please review the plan and confirm the changes are expected.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning - Large Number of Resources to be Destroyed.

core-vpc-test
Plan: 0 to add, 0 to change, 9 to destroy.
Please review the plan and confirm the changes are expected.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected a number of resources are to be deleted. Please review the plan and confirm the changes are expected.

Copy link
Contributor

Terraform Plan Summary

core-vpc-test
Plan: 0 to add, 0 to change, 9 to destroy.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning - Large Number of Resources to be Destroyed.

core-vpc-development
Plan: 0 to add, 0 to change, 9 to destroy.
Please review the plan and confirm the changes are expected.

Copy link
Contributor

Terraform Plan Summary

core-vpc-development
Plan: 0 to add, 0 to change, 9 to destroy.

Copy link
Contributor

Terraform Plan Summary

core-security-production
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

Trivy Scan Success

Show Output ```hcl

Trivy will check the following folders:
terraform/environments/core-shared-services


Running Trivy in terraform/environments/core-shared-services
2025-01-27T09:01:05Z INFO [vulndb] Need to update DB
2025-01-27T09:01:05Z INFO [vulndb] Downloading vulnerability DB...
2025-01-27T09:01:05Z INFO [vulndb] Downloading artifact... repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-27T09:01:07Z INFO [vulndb] Artifact successfully downloaded repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-27T09:01:07Z INFO [vuln] Vulnerability scanning is enabled
2025-01-27T09:01:07Z INFO [misconfig] Misconfiguration scanning is enabled
2025-01-27T09:01:07Z INFO [misconfig] Need to update the built-in checks
2025-01-27T09:01:07Z INFO [misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2025-01-27T09:01:07Z INFO [secret] Secret scanning is enabled
2025-01-27T09:01:07Z INFO [secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-27T09:01:07Z INFO [secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-27T09:01:10Z INFO [terraform scanner] Scanning root module file_path="."
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_subnet.live-data-additional" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_vpc_endpoint_route_table_association.vpc_gateway_endpoints" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_security_group.image_builder_security_group" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_security_group.interface_endpoint_security_group" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_security_group_rule.image_builder_egress_443" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_security_group_rule.image_builder_egress_80" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable. block="aws_security_group_rule.interface_endpoint-security_group_rule" value="cty.NilVal"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-dc-a"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-dc-a"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-dc-b"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-dc-b"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-rdlic"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-rdlic"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-hmpp-rdlic"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-hmpp-rdlic"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-live-data"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-live-data"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-non-live-data"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-non-live-data"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-hmpp-root"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-hmpp-root"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-noms-root"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-noms-root"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-infra-int"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-infra-int"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-dc-a"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-dc-a"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-dc-b"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-dc-b"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-azure-rdlic"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-azure-rdlic"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_instance.ad_fixngo["ad-hmpp-rdlic"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo["ad-hmpp-rdlic"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-live-data"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-live-data"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-non-live-data"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo["ad-fixngo-non-live-data"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-hmpp-root"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-hmpp-root"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-noms-root"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-azure-noms-root"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z ERROR [terraform evaluator] Failed to expand dynamic block. block="aws_route53_resolver_rule.ad_fixngo["ad-fixngo-infra-int"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo["ad-fixngo-infra-int"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:24Z ERROR [terraform evaluator] Failed to load module. Maybe try 'terraform init'? err="open terraform/modules/ip_addresses: no such file or directory"
2025-01-27T09:01:32Z INFO [terraform scanner] Scanning root module file_path="test/test_terraform"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:84"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:84"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:96"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:96"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:111"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:111"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:123"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:123"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:135"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:135"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="instance-scheduler-lambda-function.tf:80-83"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-sns-enable-topic-encryption" range="instance-scheduler-lambda-function.tf:86-89"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO [terraform executor] Ignore finding rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z INFO Number of language-specific files num=1
2025-01-27T09:01:34Z INFO [gomod] Detecting vulnerabilities...
2025-01-27T09:01:34Z INFO Detected config files num=6
trivy_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
terraform/environments/core-shared-services

*****************************

Running Checkov in terraform/environments/core-shared-services
Excluding the following checks: CKV_GIT_1,CKV_AWS_126,CKV2_AWS_38,CKV2_AWS_39
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-github-oidc-provider?ref=82f546bd5f002674138a2ccdade7d7618c6758b3:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-cross-account-access?ref=6819b090bce6d3068d55c7c7b9b3fd18c9dca648:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/terraform-aws-observability-platform-tenant?ref=fbbe5c8282786bcc0a00c969fe598e14f12eea9b:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-lambda-function?ref=5a3c02a071519986a0ae415168fb4f9d3fb7970f:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-pagerduty-integration?ref=0179859e6fafc567843cd55c0b05d325d5012dc4:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=8688bc15a08fbf5a4f4eef9b7433c5a417df8df1:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-environments//terraform/modules/ip_addresses?ref=29c48e315aa5eeef5d604617169b2f6db953966e:None (for external modules, the --download-external-modules flag is required)
2025-01-27 09:01:37,062 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-ssm-patching.git?ref=d1be56ad6bceeee3fb0a1beb9ad0d61ea07d0259:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 1239, Failed checks: 0, Skipped checks: 248


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.9.1)
tflint will check the following folders:
terraform/environments/core-shared-services

*****************************

Running tflint in terraform/environments/core-shared-services
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

Trivy Scan Success

Show Output
*****************************

Trivy will check the following folders:
terraform/environments/core-shared-services

*****************************

Running Trivy in terraform/environments/core-shared-services
2025-01-27T09:01:05Z	INFO	[vulndb] Need to update DB
2025-01-27T09:01:05Z	INFO	[vulndb] Downloading vulnerability DB...
2025-01-27T09:01:05Z	INFO	[vulndb] Downloading artifact...	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-27T09:01:07Z	INFO	[vulndb] Artifact successfully downloaded	repo="public.ecr.aws/aquasecurity/trivy-db:2"
2025-01-27T09:01:07Z	INFO	[vuln] Vulnerability scanning is enabled
2025-01-27T09:01:07Z	INFO	[misconfig] Misconfiguration scanning is enabled
2025-01-27T09:01:07Z	INFO	[misconfig] Need to update the built-in checks
2025-01-27T09:01:07Z	INFO	[misconfig] Downloading the built-in checks...
164.50 KiB / 164.50 KiB [---------------------------------------------------------] 100.00% ? p/s 0s2025-01-27T09:01:07Z	INFO	[secret] Secret scanning is enabled
2025-01-27T09:01:07Z	INFO	[secret] If your scanning is slow, please try '--scanners vuln' to disable secret scanning
2025-01-27T09:01:07Z	INFO	[secret] Please see also https://aquasecurity.github.io/trivy/v0.57/docs/scanner/secret#recommendation for faster secret detection
2025-01-27T09:01:10Z	INFO	[terraform scanner] Scanning root module	file_path="."
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_subnet.live-data-additional" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_vpc_endpoint_route_table_association.vpc_gateway_endpoints" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_security_group.image_builder_security_group" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_security_group.interface_endpoint_security_group" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_security_group_rule.image_builder_egress_443" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_security_group_rule.image_builder_egress_80" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand block. Invalid "for-each" argument. Must be known and iterable.	block="aws_security_group_rule.interface_endpoint-security_group_rule" value="cty.NilVal"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-dc-a\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-dc-a\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-dc-b\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-dc-b\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-rdlic\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-rdlic\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-hmpp-rdlic\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-hmpp-rdlic\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-live-data\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-live-data\"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-non-live-data\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-non-live-data\"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-hmpp-root\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-hmpp-root\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-noms-root\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-noms-root\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-infra-int\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-infra-int\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-dc-a\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-dc-a\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-dc-b\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-dc-b\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-azure-rdlic\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-azure-rdlic\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_instance.ad_fixngo[\"ad-hmpp-rdlic\"]" err="1 error occurred:\n\t* invalid for-each in aws_instance.ad_fixngo[\"ad-hmpp-rdlic\"].dynamic.ephemeral_block_device block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-live-data\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-live-data\"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-non-live-data\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_endpoint.ad_fixngo[\"ad-fixngo-non-live-data\"].dynamic.ip_address block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-hmpp-root\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-hmpp-root\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-noms-root\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-azure-noms-root\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:10Z	ERROR	[terraform evaluator] Failed to expand dynamic block.	block="aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-infra-int\"]" err="1 error occurred:\n\t* invalid for-each in aws_route53_resolver_rule.ad_fixngo[\"ad-fixngo-infra-int\"].dynamic.target_ip block: cannot use a cty.NilVal value in for_each. An iterable collection is required\n\n"
2025-01-27T09:01:24Z	ERROR	[terraform evaluator] Failed to load module. Maybe try 'terraform init'?	err="open terraform/modules/ip_addresses: no such file or directory"
2025-01-27T09:01:32Z	INFO	[terraform scanner] Scanning root module	file_path="test/test_terraform"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:84"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:84"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:96"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:96"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:111"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:111"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:123"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:123"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:135"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-excessive-port-access" range="vpc_additional_cidr.tf:135"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ec2-no-public-egress-sgr" range="ad-fixngo.tf:1075"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="instance-scheduler-lambda-function.tf:80-83"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-sns-enable-topic-encryption" range="instance-scheduler-lambda-function.tf:86-89"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	[terraform executor] Ignore finding	rule="aws-ecr-repository-customer-key" range="../../modules/app-ecr-repo/main.tf:7-9"
2025-01-27T09:01:34Z	INFO	Number of language-specific files	num=1
2025-01-27T09:01:34Z	INFO	[gomod] Detecting vulnerabilities...
2025-01-27T09:01:34Z	INFO	Detected config files	num=6
trivy_exitcode=0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected a number of resources are to be deleted. Please review the plan and confirm the changes are expected.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning - Large Number of Resources to be Destroyed.

core-logging-production
Plan: 0 to add, 0 to change, 6 to destroy.
Please review the plan and confirm the changes are expected.

Copy link
Contributor

Terraform Plan Summary

core-logging-production
Plan: 0 to add, 0 to change, 6 to destroy.

Copy link
Contributor

Terraform Plan Summary

core-network-services-production
No changes. Your infrastructure matches the configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terraform plan evaluation detected a number of resources are to be deleted. Please review the plan and confirm the changes are expected.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Warning - Large Number of Resources to be Destroyed.

core-shared-services-production
Plan: 0 to add, 1 to change, 8 to destroy.
Please review the plan and confirm the changes are expected.

Copy link
Contributor

Terraform Plan Summary

core-shared-services-production
Plan: 0 to add, 1 to change, 8 to destroy.

@mikereiddigital mikereiddigital deleted the issue/8695 branch January 27, 2025 10:42
@mikereiddigital mikereiddigital mentioned this pull request Jan 27, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant