Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Remove next_action_link helper method #7576

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

agoldstone93
Copy link
Contributor

What

Remove next_action_link as the functionality can just as easily be provided with the govuk_button_link_to method from the govuk_components gem

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the chore-remove-next-action-link branch from 9a3ecd9 to 1ea35fb Compare January 13, 2025 14:40
@agoldstone93 agoldstone93 marked this pull request as ready for review January 13, 2025 15:14
@agoldstone93 agoldstone93 requested a review from a team as a code owner January 13, 2025 15:14
<p class="govuk-body"><%= intro_text %></p>
<p class="govuk-body"><%= balance_text %></p>

<%= govuk_button_link_to(continue_text, forward_path) %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need the govuk-!-padding-top-3 still? as did this one app/views/citizens/accounts/index.html.erb

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsugarman I removed it intentionally because it was just a standard button below a standard paragraph so I thought it should have the default padding. Happy to put it back in if you think I should though

Remove next_action_link as the functionality can just as easily be provided
with the govuk_button_link_to method from the govuk_components gem
@agoldstone93 agoldstone93 force-pushed the chore-remove-next-action-link branch from 1ea35fb to 9970611 Compare January 15, 2025 09:24
@agoldstone93 agoldstone93 merged commit 63229b6 into main Jan 15, 2025
15 checks passed
@agoldstone93 agoldstone93 deleted the chore-remove-next-action-link branch January 15, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants