Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: simplify panel markup on citizen journey #7574

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

agoldstone93
Copy link
Contributor

What

Panel markup on citizen journey was previously unnecessarily complex. Simplify this to keep in line with rest of the codebase and use default spacing.

Screenshots

Before

image

After

image

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman assigned jsugarman and unassigned jsugarman Jan 13, 2025
@jsugarman jsugarman self-requested a review January 13, 2025 13:55
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agoldstone93 agoldstone93 marked this pull request as ready for review January 13, 2025 13:56
@agoldstone93 agoldstone93 requested a review from a team as a code owner January 13, 2025 13:56
@agoldstone93 agoldstone93 merged commit 0c9282e into main Jan 13, 2025
16 checks passed
@agoldstone93 agoldstone93 deleted the chore-simplify-panel-markup-on-citizen-journey branch January 13, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants