Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5572 Use summary card component for CYA income page #7567

Merged
merged 6 commits into from
Jan 24, 2025
Merged

AP-5572 Use summary card component for CYA income page #7567

merged 6 commits into from
Jan 24, 2025

Conversation

RoseSAK
Copy link
Contributor

@RoseSAK RoseSAK commented Jan 8, 2025 •
edited
Loading

What

Link to story

Replace instances of govuk-summary-list(card) with the actual summary card component (govuk-summary-card) on the Check your answers Income page.
Make other visual changes such as updating headings and content.
Change the page template width to full, and the card columns widths to one third each.
Update rspecs and feature tests and ensure all CYA income sections are covered in feature tests.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch 3 times, most recently from e5e795d to 2ecacfe Compare January 14, 2025 16:11
@RoseSAK RoseSAK marked this pull request as ready for review January 14, 2025 16:14
@RoseSAK RoseSAK requested a review from a team as a code owner January 14, 2025 16:14
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch from 65ef246 to b5bac5e Compare January 15, 2025 10:47
RoseSAK added 2 commits January 15, 2025 11:17
AP-5572 Update income CYA to use summary card component
2fa59d3 
Update partials used on the income CYA page to use the summary card component
AP-5572 income cya page
f665b35 
update rest of partials to use summary card component
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch 8 times, most recently from fa0e128 to b2c894a Compare January 15, 2025 15:46
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch from b2c894a to 7770fb8 Compare January 15, 2025 16:04
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch 3 times, most recently from 95e7940 to 6eabf0c Compare January 20, 2025 11:08
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch from 6eabf0c to f532a6b Compare January 20, 2025 11:26
@RoseSAK RoseSAK added the ready for review Please review label Jan 20, 2025
jsugarman
jsugarman reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

I have made a start but have to head off so will try and finish tomorrow

config/locales/en/providers.yml Show resolved Hide resolved
config/locales/en/shared.yml Outdated Show resolved Hide resolved
config/locales/en/shared.yml Outdated Show resolved Hide resolved
config/locales/en/shared.yml Outdated Show resolved Hide resolved
config/locales/en/shared.yml Outdated Show resolved Hide resolved
app/views/shared/check_answers/_payments_summary.html.erb Outdated Show resolved Hide resolved
app/views/shared/check_answers/_cash_payments.html.erb Outdated Show resolved Hide resolved
app/views/shared/check_answers/_employed_income.html.erb Outdated Show resolved Hide resolved
app/views/shared/check_answers/_employed_income.html.erb Outdated Show resolved Hide resolved
jsugarman
jsugarman reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot see any obvious issues other than those listed individually.

I guess it will just need some careful UAT on the client partner stuff.

app/views/shared/check_answers/_cash_payments.html.erb Outdated Show resolved Hide resolved
app/views/shared/review_application/_income_payments_and_assets.html.erb Outdated Show resolved Hide resolved
...ews/shared/review_application/_income_payments_and_assets_for_bank_statement_upload.html.erb Outdated Show resolved Hide resolved
@RoseSAK RoseSAK force-pushed the ap-5572-cya-income-update branch from c366969 to b250880 Compare January 22, 2025 12:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jsugarman jsugarman added UAT approved Approved by code reviewers and removed ready for review Please review labels Jan 23, 2025
@colinbruce colinbruce merged commit 7708830 into main Jan 24, 2025
15 checks passed
@colinbruce colinbruce deleted the ap-5572-cya-income-update branch January 24, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsugarman jsugarman jsugarman approved these changes

Assignees
No one assigned
Labels
approved Approved by code reviewers UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RoseSAK @jsugarman @colinbruce