Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5659: Bump ruby 3.4.1 #7558

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

AP-5659: Bump ruby 3.4.1 #7558

wants to merge 6 commits into from
+45 −25

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Dec 30, 2024 •
edited
Loading

What

Bump ruby 3.3.6 to 3.4.1

Link to story

Also, add label docker image author details

TODO

  • Check why grover was downgraded - last version that did not restrict ruby version was 0.12.3, hence the downgrade to that version
  • test grover 0.12.3 and decide on whether to go with it, wait or fork - on hold til grover gem bumped grover 1.2.2 released and supports 3.4.1

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman requested a review from a team as a code owner December 30, 2024 12:29
@jsugarman jsugarman changed the title AP-5659: Bumper ruby 3.4.1 AP-5659: Bump ruby 3.4.1 Dec 30, 2024
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from 9c10313 to e656290 Compare December 30, 2024 12:40
jsugarman
jsugarman commented Dec 30, 2024
View reviewed changes
Gemfile.lock Outdated Show resolved Hide resolved
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from e656290 to a53cbfc Compare December 30, 2024 12:54
@jsugarman jsugarman marked this pull request as draft January 6, 2025 12:12
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch 2 times, most recently from c0a4d51 to fd48b9e Compare January 7, 2025 13:57
@jsugarman jsugarman removed the blocked label Jan 7, 2025
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from 47e135e to b9d5797 Compare January 7, 2025 16:50
@jsugarman
Copy link
Contributor Author

jsugarman commented Jan 9, 2025 •
edited
Loading

Agreed in devtime to pause Civil Apply ruby 3.4.1 bump until grover gem is resolved, at least grover bumped

@jsugarman jsugarman added On Hold Temporarily halting blocked and removed Discussion labels Jan 9, 2025
@jsugarman
Bump ruby 3.3.6 to 3.4.1
09ce822
@jsugarman
Chore: Add label auther details
5d2e932
@jsugarman
AP-5659: Bump cucumber 9.2.0 to 9.2.1
4a3ccfd 
9.2.0 Has an error against ruby 3.4

```shell
<internal:hash>:37:in 'initialize': unknown keywords: :strict, :proc (ArgumentError)
```

This [issue](cucumber/cucumber-ruby#1769) covers the issue
@jsugarman
AP-5659: Freeze string literals and use unary + for mutable strings
4ea89d0 
Handle deprecation notices warning of ruby 4.0 intention to default
string literals to be frozen/immutable.

```shell
/Users/joel.sugarman/github/ministryofjustice/laa-apply-for-legal-aid/app/helpers/hash_format_helper.rb:23:
  warning: literal string will be frozen in the future (run with --debug-frozen-string-literal for more information)
```
@jsugarman
AP-5659: Bump govuk_design_system_formbuilder 5.7.1 to 5.8.0
3e9d6ed 
Handles deprecation warning for frozen_string_literals in 3.4 and
will break in 3.5.
@jsugarman jsugarman force-pushed the ap-5659/bump-ruby-3.4.1 branch from b9d5797 to 3e9d6ed Compare January 13, 2025 19:49
@jsugarman
AP-5659: Bump grover to 1.2.2
0d922d6 
Released yesterday, adding ruby 3.4.1 support
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jsugarman jsugarman added ready for review Please review and removed blocked On Hold Temporarily halting labels Jan 14, 2025
agoldstone93
agoldstone93 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Also pulled down and tested locally and everything seems to be working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoldstone93 agoldstone93 agoldstone93 approved these changes

Assignees
No one assigned
Labels
ready for review Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsugarman @agoldstone93