Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5442: Implement SCA firm permissions #7422

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Nov 12, 2024

What

Link to story

This implements a special_children_act role in the permissions table
It then ensures that, once the feature flag is enabled, only a provider with the role set is able to search for SCA proceedings

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5442/sca-firm-permissions branch 3 times, most recently from 5503629 to f968188 Compare November 12, 2024 11:50
@colinbruce colinbruce added the ready for review Please review label Nov 12, 2024
@colinbruce colinbruce marked this pull request as ready for review November 12, 2024 12:59
@colinbruce colinbruce requested a review from a team as a code owner November 12, 2024 12:59
Copy link
Contributor

@jsugarman jsugarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colinbruce colinbruce force-pushed the ap-5442/sca-firm-permissions branch from 84ce6fd to 78bf544 Compare November 13, 2024 11:16
@colinbruce colinbruce merged commit e11752d into main Nov 13, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5442/sca-firm-permissions branch November 13, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants