Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update UAT digest Rake task exclusion #7420

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

colinbruce
Copy link
Contributor

What

It became problematic to test the digest on UAT branches when you have to comment out code that is tested...

This allows a dev to run the task with a BYPASS= ENVVAR to get a branch to run the export on demand without additional code changes

It also outputs a warning to guide us when it occurs

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce marked this pull request as ready for review November 11, 2024 15:05
@colinbruce colinbruce requested a review from a team as a code owner November 11, 2024 15:05
@colinbruce colinbruce added the ready for review Please review label Nov 11, 2024
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🎖️ 👍

It became problematic to test the digest on UAT branches when
you have to comment out code that is tested...

This allows a dev to run the task with a `BYPASS=` ENVVAR to
get a branch to run the export on demand without additional
code changes

It also outputs a warning to guide us when it occurs
@colinbruce colinbruce force-pushed the chore/digest-job-helper branch from 84924a2 to 1381d54 Compare November 12, 2024 07:25
Copy link

@colinbruce colinbruce merged commit 411e1f8 into main Nov 13, 2024
14 checks passed
@colinbruce colinbruce deleted the chore/digest-job-helper branch November 13, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants