Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5393: Update SCA client declaration page #7416

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

colinbruce
Copy link
Contributor

What

Link to story

Update the handling on the view to be reliant on the age of the applicant rather than proceeding types (SCA)

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce added the ready for review Please review label Nov 11, 2024
@colinbruce colinbruce marked this pull request as ready for review November 11, 2024 10:02
@colinbruce colinbruce requested a review from a team as a code owner November 11, 2024 10:02
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking comment

Change the logic so it is dependant on the client age, rather
than application data to show the under 18 declaration
@colinbruce colinbruce force-pushed the ap-5393/sca-confirm-client-declaration branch from 076b9a4 to 10bb5dd Compare November 12, 2024 11:49
@colinbruce colinbruce merged commit bd5cbf3 into main Nov 13, 2024
15 checks passed
@colinbruce colinbruce deleted the ap-5393/sca-confirm-client-declaration branch November 13, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants