Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5424: Add capital disregards CYA, review & print/certificate and means report #7410

Merged
merged 3 commits into from
Nov 11, 2024
Merged

AP-5424: Add capital disregards CYA, review & print/certificate and means report #7410

merged 3 commits into from
Nov 11, 2024

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Nov 7, 2024 •
edited
Loading

What

Implement designs for capital disregards CYA, review & print/certificate and means report

Link to story

Inline with designs

Changes

CYA/R&P/Certificate page capital disregards

Screenshot 2024-11-07 at 16 06 11

Means report changes

Screenshot 2024-11-07 at 23 37 48

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman force-pushed the ap-5424/add-capital-disregards-cya-review-print-means-report branch from d4fc062 to 6c49eae Compare November 7, 2024 16:13
@jsugarman jsugarman changed the base branch from main to ap-5349-build-add-details-page November 7, 2024 16:14
@jsugarman jsugarman force-pushed the ap-5424/add-capital-disregards-cya-review-print-means-report branch 7 times, most recently from 1fff8d2 to 4c18990 Compare November 8, 2024 18:56
@jsugarman jsugarman marked this pull request as ready for review November 8, 2024 19:06
@jsugarman jsugarman requested a review from a team as a code owner November 8, 2024 19:06
@jsugarman jsugarman added the ready for review Please review label Nov 8, 2024
@skdejong skdejong force-pushed the ap-5349-build-add-details-page branch 3 times, most recently from 77b81c2 to afc5dc8 Compare November 11, 2024 11:28
@jsugarman
AP-5424: Display capital disregards on CYA, R&P and certificate page
5ca90dd 
Inline with designs. The CYA page, review and print page and certifcate
page all share the same partials.
@jsugarman
AP-5424: Add capital disregards to means report inline with designs
ab94c38 
The means report incarnation of the capital disregards is designed
differently to check your answers (and review and print/certifcate)
pages. This applies the designs without changing the overall sharing
of partials too dramatically.
@jsugarman jsugarman force-pushed the ap-5424/add-capital-disregards-cya-review-print-means-report branch from 4c18990 to 876e856 Compare November 11, 2024 11:39
@jsugarman
AP-5424: Add specs and feature tests for CYA, R&P and means report
d53546f 
Add post-MTRA feature test scenarios and unit ttest the helper
@jsugarman jsugarman force-pushed the ap-5424/add-capital-disregards-cya-review-print-means-report branch from 876e856 to d53546f Compare November 11, 2024 12:05
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jsugarman jsugarman merged commit 526d24a into ap-5349-build-add-details-page Nov 11, 2024
9 checks passed
@jsugarman jsugarman deleted the ap-5424/add-capital-disregards-cya-review-print-means-report branch November 11, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoldstone93 agoldstone93 agoldstone93 left review comments

@naseberry naseberry naseberry left review comments

Assignees
No one assigned
Labels
ready for review Please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsugarman @naseberry @agoldstone93