Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5474: Add start date for MTR-A feature flag #7409

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Nov 7, 2024

What

Link to story

This adds the following start date to each environment:

  • UAT: 6 November 2024, as the date has passed, it will be enabled immediately the switch is enabled
  • Staging: 12 November 2024, allows testing before the meeting on the 13th
  • Production: 20 November 2024, actual release date
    The application will fallback to the 20th November in case an environment variable gets deleted or corrupted

The Setting model is updated to check for the radio button being set to true and the current date being equal to, or greater than, the start date

It also displays the date on the admin page for confirmation

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-5474/schedule-mtra-feature-flag-v2 branch from e781468 to eea6265 Compare November 7, 2024 13:11
This adds the following start date to each environment:
    UAT: 6 November 2024, as the date has passed, it will be enabled immediately the switch is enabled
    Staging: 12 November 2024, allows testing before the meeting on the 13th
    Production: 20 Novmeber 2024, actual release date

The Setting model is updated to check for the radio button being set to true and
 the current date being equal to, or greater than, the start date
@colinbruce colinbruce force-pushed the ap-5474/schedule-mtra-feature-flag-v2 branch from eea6265 to 705250d Compare November 7, 2024 13:36
@colinbruce colinbruce marked this pull request as ready for review November 7, 2024 13:52
@colinbruce colinbruce requested a review from a team as a code owner November 7, 2024 13:52
@colinbruce colinbruce added the ready for review Please review label Nov 7, 2024
Copy link
Contributor

@naseberry naseberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinbruce colinbruce added UAT and removed ready for review Please review labels Nov 7, 2024
@colinbruce colinbruce force-pushed the ap-5474/schedule-mtra-feature-flag-v2 branch 2 times, most recently from ad2e4be to a2dbbdd Compare November 8, 2024 14:22
Use base level Setting.means_test_review_a? as this calls the
additional date logic
@colinbruce colinbruce force-pushed the ap-5474/schedule-mtra-feature-flag-v2 branch from a2dbbdd to f157ad0 Compare November 8, 2024 14:31
Copy link

sonarqubecloud bot commented Nov 8, 2024

@colinbruce colinbruce added Ready to merge Has passed UAT testing and can be merged into master and removed UAT labels Nov 8, 2024
@colinbruce colinbruce merged commit 7473e4b into main Nov 11, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5474/schedule-mtra-feature-flag-v2 branch November 11, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Has passed UAT testing and can be merged into master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants