Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5443: Change review and print heading from h1 to h2 #7407

Merged
merged 1 commit into from
Nov 7, 2024
Merged

AP-5443: Change review and print heading from h1 to h2 #7407

merged 1 commit into from
Nov 7, 2024

Conversation

agoldstone93
Copy link
Contributor

What

Link to story

Change review and print heading from h1 to h2

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-5443-review-and-print-change-h1-to-h2 branch from 1abe18a to addefff Compare November 6, 2024 16:10
@agoldstone93 agoldstone93 marked this pull request as ready for review November 6, 2024 16:26
@agoldstone93 agoldstone93 requested a review from a team as a code owner November 6, 2024 16:26
kmahern
kmahern approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@agoldstone93
AP-5443: Change review and print heading from h1 to h2
a1a2fd9 
Update feature tests to reflect changes
@agoldstone93 agoldstone93 force-pushed the ap-5443-review-and-print-change-h1-to-h2 branch from addefff to a1a2fd9 Compare November 7, 2024 12:17
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit f0b6e9e into main Nov 7, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the ap-5443-review-and-print-change-h1-to-h2 branch November 7, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahern kmahern kmahern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoldstone93 @kmahern