AP-5434: CYA update - convert existing summary lists to cards

[agoldstone93]

What

Link to story

• Update summary lists on each CYA page and means/merits reports to include a flag which makes them a summary card
• Convert non summary list/card (often custom) markup to use summary card component
• Remove redundant logic, unnecessary spacing and unused partials

NB. Feature test in features/providers/partner_means_assessment/means_report.feature has been updated and is offering the same test coverage as before. There is a bug (AP-5479) which has been raised and when it is addressed, the values in this feature test will change

Checklist

Before you ask people to review this PR:

• Tests and rubocop should be passing: bundle exec rake
• Github should not be reporting conflicts; you should have recently run git rebase main.
• The standards in the Git Workflow document on Confluence should be followed
• There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
• The PR description should say what you changed and why, with a link to the JIRA story.
• You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
• You should have checked that the commit messages say why the change was made.

[colinbruce]

If this is check_answers, should they not have change links?
I'd expect the reports to not have change links.
The deleted code had <% read_only = false unless local_assigns.key?(:read_only) %> to check

[agoldstone93]

@colinbruce Looks like the only place this is ever called is in partials in the means report, which is why change links are gone. With that in mind, do you think this partial would be better off in the /means_reports folder instead?

[colinbruce]

minor nit pick: this could be clearer as partner? to show it's a boolean check
Further down it reads as partner object
if partner && !partner_exclude_items.include?(item.value_method)

[colinbruce]

Slightly 🤯 but nothing serious in my review...
I think UAT will be the proof in the pudding on this one though! 😄

[colinbruce]

Reviewed additional changes - 👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud