Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ap-5338: add sca fields to application details report #7405

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Nov 6, 2024

What

Link to story

Added biological_parent?, parental_responsibility_order?, child_subject? and autogranted? columns to the application digest and additionally child_subject_client_involvement_type? to the application details report.

Whether or not the application is an SCA application can already be determined from the matter_types column and similarly the applicant age from the applicant_age column.

TODO

After discussions, it was decided that it was best to wait to populate the auto_grant_special_children_act? on the LegalAidApplication model until after the autogrant work is complete.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@kmahern kmahern force-pushed the ap-5338-add-sca-info-to-digest branch 4 times, most recently from 1d198a4 to 305d523 Compare November 7, 2024 12:23
@kmahern kmahern marked this pull request as ready for review November 7, 2024 14:03
@kmahern kmahern requested a review from a team as a code owner November 7, 2024 14:03
@kmahern kmahern force-pushed the ap-5338-add-sca-info-to-digest branch 2 times, most recently from d27cc9a to 33e98a1 Compare November 7, 2024 14:58
colinbruce
colinbruce previously approved these changes Nov 8, 2024
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinbruce colinbruce dismissed their stale review November 8, 2024 08:49

I found something missing while rebasing my branch

def parental_responsibility_order_relationship?
proceedings.any? { |proceeding| proceeding.relationship_to_child.eql?("court_order") }
end

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to track parental responsibility agreements as well

  def parental_responsibility_agreement_relationship?
    proceedings.any? { |proceeding| proceeding.relationship_to_child.eql?("parental_responsibility_agreement") }
  end

This will need adding at each stage.

In the mapping there is a requirement for

Have they stated the supporting evidence for this (follow up questions) is either via court order OR via a PR agreement.

My CCMS code already has something similar. Happy to pair if needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I have added a new method to the legal_aid_application model parental_responsibility_evidence? and am reporting this on both the digest and the application_details report - do you think this meets the requirement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 added new parental_responsibility_court_order_relationship? and parental_responsibility_agreement_relationship? methods to the legal_aid_application model and am reporting both of these on the digest and application details report.

@kmahern kmahern force-pushed the ap-5338-add-sca-info-to-digest branch 2 times, most recently from 22aaead to 9eb7e68 Compare November 11, 2024 11:22
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kmahern kmahern force-pushed the ap-5338-add-sca-info-to-digest branch from a2c8255 to 587a53e Compare November 11, 2024 14:08
@kmahern kmahern force-pushed the ap-5338-add-sca-info-to-digest branch from 587a53e to 6890b6b Compare November 13, 2024 08:31
Copy link

@kmahern kmahern merged commit f998a0b into main Nov 13, 2024
15 checks passed
@kmahern kmahern deleted the ap-5338-add-sca-info-to-digest branch November 13, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants