-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ap-5338: add sca fields to application details report #7405
Conversation
1d198a4
to
305d523
Compare
d27cc9a
to
33e98a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I found something missing while rebasing my branch
def parental_responsibility_order_relationship? | ||
proceedings.any? { |proceeding| proceeding.relationship_to_child.eql?("court_order") } | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to track parental responsibility agreements as well
def parental_responsibility_agreement_relationship?
proceedings.any? { |proceeding| proceeding.relationship_to_child.eql?("parental_responsibility_agreement") }
end
This will need adding at each stage.
In the mapping there is a requirement for
Have they stated the supporting evidence for this (follow up questions) is either via court order OR via a PR agreement.
My CCMS code already has something similar. Happy to pair if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I have added a new method to the legal_aid_application model parental_responsibility_evidence? and am reporting this on both the digest and the application_details report - do you think this meets the requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 added new parental_responsibility_court_order_relationship? and parental_responsibility_agreement_relationship? methods to the legal_aid_application model and am reporting both of these on the digest and application details report.
22aaead
to
9eb7e68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
a2c8255
to
587a53e
Compare
587a53e
to
6890b6b
Compare
Quality Gate passedIssues Measures |
What
Link to story
Added biological_parent?, parental_responsibility_order?, child_subject? and autogranted? columns to the application digest and additionally child_subject_client_involvement_type? to the application details report.
Whether or not the application is an SCA application can already be determined from the matter_types column and similarly the applicant age from the applicant_age column.
TODO
After discussions, it was decided that it was best to wait to populate the auto_grant_special_children_act? on the LegalAidApplication model until after the autogrant work is complete.
Checklist
Before you ask people to review this PR:
bundle exec rake
git rebase main
.