Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-5273: SCA level of service fix #7120

Merged
merged 4 commits into from
Aug 30, 2024
Merged

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Aug 29, 2024

What

Link to story

Update the SubstantiveDefaultsForm handling of the default level of service

On a non-sca proceeding the view stores default values and passes them as controller params to the form.

The SCA skip removed the submission of these and meant that the default LOS was not set

This updates the test to ensure the proceeding is instantiated in the same way that it occurs in the controller, i.e. no default values populated for the three substantive default level of service fields. It then updates the form to set the value using the values called from LFA and stored as form values

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

This is needed as the Level of service is nil on the form
I am about to update
The proceeding should be initialised without the default
level of service values to better reflect the actual use
This adds the default substantive levels of service as
long as the user has not selected false

For SCA, as they submit _nothing_, this ensures the
proceeding gets updated as expected - while normal
applications will submit these values via the form
params from the controller
@colinbruce colinbruce marked this pull request as ready for review August 29, 2024 13:08
@colinbruce colinbruce requested a review from a team as a code owner August 29, 2024 13:08
@colinbruce colinbruce added the ready for review Please review label Aug 29, 2024
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

This got rationalised earlier in the year and the repetition
of the level of service header got missed
Copy link

@colinbruce colinbruce added UAT and removed ready for review Please review labels Aug 29, 2024
@colinbruce colinbruce merged commit 964697e into main Aug 30, 2024
14 checks passed
@colinbruce colinbruce deleted the ap-5273/sca-level-of-service-fix branch August 30, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants