Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5231: SCA emergency references #7106

Merged
merged 8 commits into from
Sep 9, 2024
Merged

AP-5231: SCA emergency references #7106

merged 8 commits into from
Sep 9, 2024

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Aug 28, 2024 •
edited
Loading

What

Link to story

This updates the SCA flow to remove references to emergency certificates

  • The ‘Emergency application’ page should not be shown
  • The Check your answers page makes no reference to ‘Emergency’ scope or costs
  • A new certificate type has been added to the Applications page

image

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce added the ready for review Please review label Aug 29, 2024
@colinbruce colinbruce marked this pull request as ready for review August 29, 2024 07:06
@colinbruce colinbruce requested a review from a team as a code owner August 29, 2024 07:06
@colinbruce colinbruce force-pushed the ap-5231/sca-emergency-references branch from df2f7b5 to d24f1ed Compare August 29, 2024 08:18
kmahern
kmahern approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commented out code can be removed otherwise lgtm 👍

@colinbruce colinbruce force-pushed the ap-5231/sca-emergency-references branch from d24f1ed to 7ae2016 Compare August 29, 2024 12:59
@colinbruce colinbruce added UAT and removed ready for review Please review labels Aug 29, 2024
@colinbruce colinbruce force-pushed the ap-5231/sca-emergency-references branch 3 times, most recently from 84da416 to db5a904 Compare August 30, 2024 14:34
colinbruce and others added 7 commits September 4, 2024 08:50
@colinbruce @kmahern
AP-5231: Skip emergency overrides for SCA applications
39466a0 
When a user adds a delegated function date to an SCA application,
they should not see the Emergency override pages
@colinbruce @kmahern
AP-5231: Update SCA CYA proceeding section
dd78ee9 
Exclude the emergency sections when a user has selected
delegated functions on an SCA proceeding type
@colinbruce @kmahern
AP-5231: Update application list to show new certificate type
24b8915
@colinbruce @kmahern
AP-5231: Further update to proceeding loop
f8b0afc 
Allow the substantive defaults page to skip changes if
the proceeding is an SCA one
@colinbruce @kmahern
AP-5231: Update evidence labels
e1e8d85 
This allows the parental responsibility and reports to
display the file names for uploads
@colinbruce @kmahern
AP-5231: Update incomplete proceedings to handle SCA with DF
e46620c 
When delegated functions are used on an SCA proceeding, it will
set used_delegated functions to true but not set Levels of
Service or Scope limitations.  This PR adds tests and setup
for not marking these as  to avoid a recursive
loop in the proceeding loop section
@kmahern
ap-5231: don't display emergency certificate scope limitations
95a0d20 
Don't display emergency certificate scope limitations on limitations page
@kmahern kmahern force-pushed the ap-5231/sca-emergency-references branch from db5a904 to 95a0d20 Compare September 4, 2024 07:55
agoldstone93
agoldstone93 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

agoldstone93
agoldstone93 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kmahern kmahern force-pushed the ap-5231/sca-emergency-references branch from e4b63a4 to 1aa91db Compare September 5, 2024 14:39
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kmahern kmahern merged commit 3a9db2c into main Sep 9, 2024
14 checks passed
@kmahern kmahern deleted the ap-5231/sca-emergency-references branch September 9, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmahern kmahern kmahern approved these changes

@naseberry naseberry naseberry left review comments

@agoldstone93 agoldstone93 agoldstone93 approved these changes

Assignees
No one assigned
Labels
UAT
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colinbruce @naseberry @agoldstone93 @kmahern