Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap 5119 provider details api integration #7072

Merged
merged 8 commits into from
Aug 29, 2024

Conversation

kmahern
Copy link
Contributor

@kmahern kmahern commented Aug 21, 2024

What

Link to story

  • Created new PDA::ProviderDetailsRetriever and PDA::ProviderDetailsCreator classes and associated specs to enable calls to be made to the new Provider Details API.
  • These follow the patterns of the existing ProviderDetailsRetrieveer and ProviderDetailsCreator classes and have been added to a new PDA namespace so that when we want to switch over to the new Provider Details API we can simply change all refererences to ProviderDetailsCreator to PDA::ProviderDetailsCreator and everything should 🤞 work.
  • In the meantime, so that we can dual-run the old and new provider detail apis and compare results, a new class PDA::CompareProviderDetails class has been added.
  • This is called asynchronously by a new CompareProviderDetailsWorker class after provider details have been updated with the results from the existing CCMS pda call.
  • The new PDA::CompareProviderDetails class logs (to Kibana - with prefix PDA::CompareProviderDetails) whether or not the details returned by the new ProviderDetailsAPI match the provider details that have already been updated by the existing existing CCMS pda call and if not where there are differences.
  • It also logs the start and end times (and calculated duration) of the api call to the new Provider Details API.
  • This final commit on this pr is purely to allow it to be tested in uat. This pr should not be merged until this commit is removed.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@kmahern kmahern force-pushed the ap-5119-provider-details-api-integration branch 7 times, most recently from 10202c1 to 77e99c0 Compare August 27, 2024 07:53
@kmahern kmahern added the do not merge This PR should not be merged label Aug 27, 2024
Add tests for exception handling to fix code coverage
@kmahern kmahern force-pushed the ap-5119-provider-details-api-integration branch from da6fb4d to cf9755b Compare August 27, 2024 11:07
@kmahern kmahern force-pushed the ap-5119-provider-details-api-integration branch 2 times, most recently from 3e2e880 to 30b5ebd Compare August 27, 2024 11:17
@kmahern kmahern marked this pull request as ready for review August 27, 2024 14:06
@kmahern kmahern requested a review from a team as a code owner August 27, 2024 14:06
@kmahern kmahern added the ready for review Please review label Aug 27, 2024
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kmahern kmahern force-pushed the ap-5119-provider-details-api-integration branch from 67d0168 to 0ec734a Compare August 29, 2024 06:53
Copy link

@kmahern kmahern merged commit 2fe3735 into main Aug 29, 2024
14 checks passed
@kmahern kmahern deleted the ap-5119-provider-details-api-integration branch August 29, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge This PR should not be merged ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants