Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add faraday entry in Gemfile #7066

Closed
wants to merge 1 commit into from
Closed

Conversation

colinbruce
Copy link
Contributor

What

This explicitly adds Faraday, it has been used to make all of our external calls but we relied on it's presence as a dependency of other gems.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

This explicitly adds Faraday, it has been used to make all
of our external calls but we relied on it's presence as a
dependency of other gems.
Copy link

@colinbruce colinbruce changed the title Update faraday entries in Gemfile Chore: Add faraday entry in Gemfile Aug 20, 2024
@colinbruce colinbruce marked this pull request as ready for review August 20, 2024 10:19
@colinbruce colinbruce requested a review from a team as a code owner August 20, 2024 10:19
@colinbruce colinbruce added the ready for review Please review label Aug 20, 2024
@colinbruce
Copy link
Contributor Author

Included in #7067

@colinbruce colinbruce closed this Aug 20, 2024
@colinbruce colinbruce deleted the chore/add-faraday-gem branch August 20, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant