Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: State enums #7055

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Fix: State enums #7055

merged 1 commit into from
Aug 15, 2024

Conversation

colinbruce
Copy link
Contributor

What

This happnened locally and only breaks teh amdin pages If a Provider has an application at the parental relationship questions on an SCA task list, the admin page breaks. This adds the two new states into the enums and enables the admin list to work as expected

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

This happnened locally and only breaks teh amdin pages
If a Provider has an application at the parental relationship
questions on an SCA task list, the admin page breaks.  This
adds the two new states into the enums and enables the admin
list to work as expected
Copy link

@colinbruce colinbruce marked this pull request as ready for review August 15, 2024 07:26
@colinbruce colinbruce requested a review from a team as a code owner August 15, 2024 07:26
@colinbruce colinbruce added the ready for review Please review label Aug 15, 2024
Copy link
Contributor

@kmahern kmahern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@colinbruce colinbruce merged commit 3765b9f into main Aug 15, 2024
14 checks passed
@colinbruce colinbruce deleted the fix/state-changes branch August 15, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants