Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-5221: Update change links #7045

Merged
merged 2 commits into from
Aug 21, 2024
Merged

AP-5221: Update change links #7045

merged 2 commits into from
Aug 21, 2024

Conversation

agoldstone93
Copy link
Contributor

@agoldstone93 agoldstone93 commented Aug 14, 2024 •
edited
Loading

What

Link to story

  • Update change links for addresses on "check provider answers" page
  • Update specs and feature tests to reflect changes
  • Remove outdated feature test
  • Add feature test for new scenario

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@agoldstone93 agoldstone93 force-pushed the ap-5221-update-cya-change-links-for-addresses branch 4 times, most recently from 32c0d39 to 7e8a6d3 Compare August 20, 2024 08:31
@agoldstone93 agoldstone93 marked this pull request as ready for review August 20, 2024 08:40
@agoldstone93 agoldstone93 requested a review from a team as a code owner August 20, 2024 08:40
colinbruce
colinbruce approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@colinbruce colinbruce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code wise

@agoldstone93
AP-5221: Update change links to match updated designs
bfd82ff 
Change links should now go to the right pages. Correspondence address no
longer displayed on CYA if the question has not been answered. If user
has entered an office address, change link goes to right place
@agoldstone93
AP-5221: Update feature tests to reflect changes
9ba4035 
Add feature test to cover additional scenarios and update existing
features
@agoldstone93 agoldstone93 force-pushed the ap-5221-update-cya-change-links-for-addresses branch from 7e8a6d3 to 9ba4035 Compare August 21, 2024 07:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@agoldstone93 agoldstone93 merged commit 7e522fc into main Aug 21, 2024
14 checks passed
@agoldstone93 agoldstone93 deleted the ap-5221-update-cya-change-links-for-addresses branch August 21, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinbruce colinbruce colinbruce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agoldstone93 @colinbruce