Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap 5191 update proceeding search to accessible autocomplete #7019

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

skdejong
Copy link
Contributor

@skdejong skdejong commented Aug 9, 2024

What

Update proceeding search to 'accessible autocomplete'

Update proceeding search to use the GOV.UK component 'accessible autocomplete' when JavaScript is enabled and use datalink when JavaScript is off.

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@skdejong skdejong force-pushed the AP-5191-update-proceeding-search-to-accessible-autocomplete branch from 8987875 to f4f8551 Compare August 12, 2024 08:34
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant