Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP-4664: Update CFE Review Reason values #6071

Merged
merged 4 commits into from
Dec 7, 2023

Conversation

colinbruce
Copy link
Contributor

@colinbruce colinbruce commented Dec 1, 2023

What

Link to story

These are read and translated from the CFEResult object, this PR updates the current keys' output to be Client's * and adds in prefixed versions for Client's * and Partner's.

This will allow us to read the before and after cutover versions of CFECivil results

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • The standards in the Git Workflow document on Confluence should be followed
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@colinbruce colinbruce force-pushed the ap-4664/update-cfe-review-reason-handling branch from 1542b39 to 841e7f4 Compare December 1, 2023 12:09
@colinbruce colinbruce marked this pull request as ready for review December 1, 2023 12:32
@colinbruce colinbruce requested a review from a team as a code owner December 1, 2023 12:32
@colinbruce colinbruce added the ready for review Please review label Dec 1, 2023
These are read and translated from the CFEResult object, this PR
updates the current version to be `Client's *` and adds in prefixed
versions for `Client's *` and `Partner's`.

This will allow us to read the before and after cutover versions
of CFECivil results
@colinbruce colinbruce force-pushed the ap-4664/update-cfe-review-reason-handling branch from 841e7f4 to b98ceab Compare December 4, 2023 07:47
@colinbruce colinbruce added UAT approved Approved by code reviewers and removed ready for review Please review labels Dec 5, 2023
@colinbruce colinbruce force-pushed the ap-4664/update-cfe-review-reason-handling branch from ba2bd8f to cf56455 Compare December 6, 2023 12:36
@colinbruce colinbruce force-pushed the ap-4664/update-cfe-review-reason-handling branch from cf56455 to f80d864 Compare December 6, 2023 12:39
Copy link

sonarqubecloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@colinbruce colinbruce merged commit 36957a0 into main Dec 7, 2023
7 checks passed
@colinbruce colinbruce deleted the ap-4664/update-cfe-review-reason-handling branch December 7, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved by code reviewers UAT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants