Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-4575 [EXT]: Allow whitespace and case-insensitive searching #6030

Merged
merged 2 commits into from
Nov 24, 2023
Merged

AP-4575 [EXT]: Allow whitespace and case-insensitive searching #6030

merged 2 commits into from
Nov 24, 2023

Conversation

jsugarman
Copy link
Contributor

@jsugarman jsugarman commented Nov 22, 2023 •
edited
Loading

What

Allow whitespace and case-insenstive search for copy and link of cases

Link to story

So inadvertent whitespace or character case use does
not prevent users from finding otherwise valid case
references for copying or linking.

The addition of the class method to the base_form
means this could be used for other form attributes, such
as postcode (BaseAddressLookupForm)

Checklist

Before you ask people to review this PR:

  • Tests and rubocop should be passing: bundle exec rake
  • Github should not be reporting conflicts; you should have recently run git rebase main.
  • There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
  • The PR description should say what you changed and why, with a link to the JIRA story.
  • You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
  • You should have checked that the commit messages say why the change was made.

@jsugarman jsugarman changed the title Fix: Allow whitespace and case-insensitive searching AP-4575 [EXT]: Allow whitespace and case-insensitive searching Nov 22, 2023
@jsugarman jsugarman marked this pull request as ready for review November 23, 2023 09:09
@jsugarman jsugarman requested a review from a team as a code owner November 23, 2023 09:09
@jsugarman
Fix: Allow whitespace and case-insensitive searching
a12c43b 
So inadvertent whitespace or character case use does
not prevent users from find otherwise valid case
references for copying or linking.

The addition of the class method to the base_form
means this could be used for other form attributes, such
as postcode (BaseAddressLookupForm)
@jsugarman jsugarman force-pushed the fix/allow-case-insensitive-copy_case-search branch from 8f3f886 to a12c43b Compare November 23, 2023 14:36
agoldstone93
agoldstone93 approved these changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@agoldstone93 agoldstone93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jsugarman
Fix: simplify normalizes method
298e061 
For clarity. We do not need to send the before_validation
command as a message with a proc as an argument in this scenario
as we are alway going to be creating that specifc named hook. KISS
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jsugarman jsugarman merged commit 35078c0 into main Nov 24, 2023
7 checks passed
@jsugarman jsugarman deleted the fix/allow-case-insensitive-copy_case-search branch November 24, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agoldstone93 agoldstone93 agoldstone93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsugarman @agoldstone93