Ap 4503 correction to ineligible result #5982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahern
force-pushed
the
ap-4503-correction-to-ineligible-result
branch
12 times, most recently
from
24844b3 to
7bd3889
Compare
kmahern
commented
Nov 14, 2023
| result | ||
| end | ||
|
|
||
| # This result has has been faked, to cover an example where CFE returns 'ineligible' |
There was a problem hiding this comment.
Is this approach best/correct?
jsugarman
reviewed
Nov 15, 2023
kmahern
force-pushed
the
ap-4503-correction-to-ineligible-result
branch
from
6b535a1 to
d132944
Compare
jsugarman
reviewed
Nov 16, 2023
spec/requests/providers/capital_income_assessment_results_controller_spec.rb
Outdated
Show resolved
Hide resolved
jsugarman
reviewed
Nov 16, 2023
spec/requests/providers/capital_income_assessment_results_controller_spec.rb
Outdated
Show resolved
Hide resolved
jsugarman
reviewed
Nov 16, 2023
spec/requests/providers/capital_assessment_results_controller_spec.rb
Outdated
Show resolved
Hide resolved
jsugarman
reviewed
Nov 16, 2023
| # for more than one proceeding category, which it appears is currently not possible. | ||
| # Currently if an applicant is ineligible for disposable income and capital, | ||
| # CFE returns the disposable income result for proceedings as 'ineligible', | ||
| # but the capital result for proceedings as 'pending'. |
There was a problem hiding this comment.
You could add that this is due to a current "shortcut" in CFE that may be removed in the future - see LEP-349
jsugarman
approved these changes
Nov 16, 2023
There was a problem hiding this comment.
👍 A couple of test nits which I personally have been trying to address whenever i see them, plus you could add reference https://dsdmoj.atlassian.net/browse/LEP-349 in the code comment you added on the fake result payload.
kmahern
force-pushed
the
ap-4503-correction-to-ineligible-result
branch
from
ac1de22 to
92a2518
Compare
…tal_results to CFE::V6::Result
…and ineligible_disposable_capital? from helper to model also, refactor these methods to make them clearer as per suggestion
kmahern
force-pushed
the
ap-4503-correction-to-ineligible-result
branch
from
92a2518 to
5ca265a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Link to story
I have added code to handle the scenario where CFE returns 'ineligible' for multiple categories out of gross income, disposable income and capital and added a 'fake' CFE result to test this scenario, however, in practice this is not currently happening, see https://dsdmoj.atlassian.net/browse/AP-4503?focusedCommentId=342986 and https://github.com/ministryofjustice/laa-apply-for-legal-aid/pull/5982/files#r1392418804. This has been added as it is the desired way for CFE to work that is shown in the designs for this ticket but I am not sure if it is the best/correct approach?
Checklist
Before you ask people to review this PR:
bundle exec rakegit rebase main.