Skip to content

Commit

Permalink
Keep uri to below 1.0.0
Browse files Browse the repository at this point in the history
The 1.0.0+ version of URI deprecated certain URI pattern names
this in turn broke CookieJar, a deprecated gem, that is used in
em-http-request, that is required by puffing-billy.

Rather than strip out puffing-billy or wait weeks for the
maintainers of upstream gems to agree a path, we are locking this
below the breaking change
  • Loading branch information
colinbruce committed Nov 12, 2024
1 parent 2d1f995 commit 3ade567
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
7 changes: 7 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ gem "view_component"
# Catching unsafe migrations in development
gem "strong_migrations"

# TODO: Added on 12 Nov 2024 - CB
# The 1.0.0+ version of URI deprecated certain URI pattern names
# this in turn broke CookieJar, a deprecated gem, that is used in em-http-request, that is
# required by puffing-billy. Rather than strip out puffing-billy or wait weeks for the
# maintainers of upstream gems to agree a path, we are locking this below the breaking change
gem "uri", "< 1.0.0"

group :development, :test do
gem "awesome_print", "~> 1.9.2"
gem "byebug", platforms: %i[mri mingw x64_mingw]
Expand Down
3 changes: 2 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ GEM
tzinfo (>= 1.0.0)
uber (0.1.0)
unicode-display_width (2.6.0)
uri (1.0.1)
uri (0.13.1)
useragent (0.16.10)
vcr (6.3.1)
base64
Expand Down Expand Up @@ -857,6 +857,7 @@ DEPENDENCIES
super_diff
table_print
tzinfo-data
uri (< 1.0.0)
vcr
view_component
webdack-uuid_migration (~> 1.5.0)
Expand Down

0 comments on commit 3ade567

Please sign in to comment.