Merge pull request #7571 from ministryofjustice/chore/address-transac…

…tion-type-todo Chore: Address transaction type todo
ministryofjustice · Jan 13, 2025 · 1e2193c · 1e2193c
2 parents d2a3766 + ad6a666
commit 1e2193c
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 135 deletions.
diff --git a/app/helpers/user_transactions_helper.rb b/app/helpers/user_transactions_helper.rb
diff --git a/config/locales/cy/transaction_types.yml b/config/locales/cy/transaction_types.yml
@@ -2,18 +2,6 @@
 cy:
   transaction_types:
     names:
-      citizens:
-        benefits: stifeneB
-        child_care: stnemyap eracdlihC
-        excluded_benefits: stifeneb dedragersiD
-        friends_or_family: ylimaf ro sdneirf morf pleh laicnaniF
-        legal_aid: esac lanimirc a ni dia lagel sdrawot stnemyaP
-        maintenance_in: rentrap remrof a morf stnemyap ecnanetniaM
-        maintenance_out: rentrap remrof a ot stnemyap ecnanetniaM
-        pension: noisneP
-        property_or_lodger: regdol ro ytreporp a morf emocnI
-        rent_or_mortgage: stnemyap gnisuoH
-        salary: segaw ro yralaS
       providers:
         benefits: stifeneB
         child_care: stnemyap eracdlihC

diff --git a/config/locales/en/transaction_types.yml b/config/locales/en/transaction_types.yml
@@ -1,21 +1,6 @@
 en:
   transaction_types:
     names:
-      # TODO: remove this as we don't actually show transaction categories to citizens anymore, however these categories are still
-      # being used in a few places, and have tests and helper methods which will also need to be updated/removed
-      citizens:
-        benefits: Benefits, charitable or government payments
-        child_care: Childcare payments
-        excluded_benefits: Disregarded benefits
-        friends_or_family: Financial help from friends or family
-        housing_benefit: Housing Benefit
-        legal_aid: Payments towards legal aid in a criminal case
-        maintenance_in: Maintenance payments from a former partner
-        maintenance_out: Maintenance payments to a former partner
-        pension: Pension
-        property_or_lodger: Income from a property or lodger
-        rent_or_mortgage: Housing payments
-        salary: Salary or wages
       providers:
         benefits: Benefits, charitable or government payments
         child_care: Childcare payments

diff --git a/spec/helpers/user_transactions_helper_spec.rb b/spec/helpers/user_transactions_helper_spec.rb