DBA-844 #504
Merged
DBA-844 #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit Description: Refactor Alfresco Wallet Role Inclusion to Use include_role Summary of Change: Replaced the roles section for the alfresco_wallet role in playbooks/delius-artefacts-playbook.yml with a task that uses the include_role module. This ensures the role is conditionally included at runtime based on the deploy_alfresco_wallet variable. Reason for Change: Ansible pre-checks for the existence of roles in the roles section, even when they are conditionally included. This caused errors in workflows (e.g., oracle-db-mis-configuration-artefacts.yml) where the alfresco_wallet role was not needed and its directory did not exist. Using include_role delays role inclusion until the when condition is evaluated, avoiding the unnecessary pre-check and error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Description:
Refactor Alfresco Wallet Role Inclusion to Use include_role to avoid error when run from MIS Config Artefact workflow
Summary of Change:
Replaced the roles section for the alfresco_wallet role in playbooks/delius-artefacts-playbook.yml with a task that uses the include_role module. This ensures the role is conditionally included at runtime based on the deploy_alfresco_wallet variable.
Reason for Change:
Ansible pre-checks for the existence of roles in the roles section, even when they are conditionally included. This caused errors in workflows (e.g., oracle-db-mis-configuration-artefacts.yml) where the alfresco_wallet role was not needed and its directory did not exist. Using include_role delays role inclusion until the when condition is evaluated, avoiding the unnecessary pre-check and error.
Tested with workflow run "Oracle: delius-mis-dev_mis_configuration_artefacts #21"