bugfix: Ensure all date errors returned at once #2288
Merged
+164
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobmeredith
approved these changes
Jan 15, 2025
| @@ -47,7 +48,7 @@ describe('OccupancyViewController', () => { | |||
| }) | |||
|
|
|||
| beforeEach(() => { | |||
| jest.resetAllMocks() | |||
| jest.clearAllMocks() | |||
There was a problem hiding this comment.
I'm wondering why the change to just clear the mocks rather than reset? Doesn't that leave the mock implementation intact?
It's not a biggie as all the mock implementations get set up again anyway.
There was a problem hiding this comment.
Using resetAllMocks results in the describe block on line 301 to fail if run consecutively -- not entirely sure why, I suspect the way we're mocking requests and such may play a part!
Refactor of booking post handler to follow usual try/catch pattern
froddd
force-pushed
the
bugfix/show-all-booking-date-errors-at-once
branch
from
d03a928 to
fe539b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submitting a new booking without an arrival or departure date, or with either of those invalid, only one error would be indicated for the first error field, with the other field ignored. This ensures all errors are returned at once.
A small refactor of the booking post handler makes it follow the more usual
try/catchpattern.Screenshot of changes