generated from ministryofjustice/hmpps-template-typescript
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APS-1606: Day availability details #2258
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
froddd
force-pushed
the
feature/APS-1606-day-availability-details
branch
2 times, most recently
from
December 19, 2024 15:29
e73d461
to
f6a890d
Compare
froddd
force-pushed
the
feature/APS-1606-day-availability-details
branch
3 times, most recently
from
December 19, 2024 16:11
c67bb2e
to
4b6d6ae
Compare
Also adds an ISO date property to the calendar day for reuse in the templates.
bobmeredith
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good.
There may be a merge conflict around the .njk though.
froddd
force-pushed
the
feature/APS-1606-day-availability-details
branch
from
January 7, 2025 09:47
4b6d6ae
to
296f167
Compare
Commit integration tests.
froddd
force-pushed
the
feature/APS-1606-day-availability-details
branch
from
January 7, 2025 09:57
296f167
to
ea86662
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://dsdmoj.atlassian.net/browse/APS-1606
Changes in this PR
Implements the day availability detailed view. Calendar on occupancy view now links to this.
It has been assumed that the numbers shown on that page should match those shown on the calendar view, so this may return negative numbers when there is no availability for a given criteria (or globally).
Screenshots of UI changes