Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APS-1606: Day availability details #2258

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

froddd
Copy link
Contributor

@froddd froddd commented Dec 18, 2024

Context

https://dsdmoj.atlassian.net/browse/APS-1606

Changes in this PR

Implements the day availability detailed view. Calendar on occupancy view now links to this.

It has been assumed that the numbers shown on that page should match those shown on the calendar view, so this may return negative numbers when there is no availability for a given criteria (or globally).

Screenshots of UI changes

Screenshot 2024-12-19 at 15 37 12 Screenshot 2024-12-19 at 15 38 29 Screenshot 2024-12-19 at 15 39 11

@froddd froddd force-pushed the feature/APS-1606-day-availability-details branch 2 times, most recently from e73d461 to f6a890d Compare December 19, 2024 15:29
@froddd froddd marked this pull request as ready for review December 19, 2024 15:39
@froddd froddd force-pushed the feature/APS-1606-day-availability-details branch 3 times, most recently from c67bb2e to 4b6d6ae Compare December 19, 2024 16:11
Copy link
Contributor

@bobmeredith bobmeredith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good.
There may be a merge conflict around the .njk though.

server/utils/match/occupancy.test.ts Outdated Show resolved Hide resolved
server/utils/match/occupancy.test.ts Outdated Show resolved Hide resolved
@froddd froddd force-pushed the feature/APS-1606-day-availability-details branch from 4b6d6ae to 296f167 Compare January 7, 2025 09:47
@froddd froddd force-pushed the feature/APS-1606-day-availability-details branch from 296f167 to ea86662 Compare January 7, 2025 09:57
@froddd froddd enabled auto-merge January 7, 2025 09:58
@froddd froddd merged commit 7af098c into main Jan 7, 2025
7 checks passed
@froddd froddd deleted the feature/APS-1606-day-availability-details branch January 7, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants