Moved verifyApiPost to journeyUtils as a cypress task to be used else…

…where
ministryofjustice · Nov 19, 2024 · 575e1e0 · 575e1e0
1 parent 1f1317a
commit 575e1e0
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 15 deletions.
diff --git a/cypress.config.ts b/cypress.config.ts
@@ -10,7 +10,7 @@ import outOfServiceBed from './integration_tests/mockApis/outOfServiceBed'
 import person from './integration_tests/mockApis/person'
 import reports from './integration_tests/mockApis/reports'
 import applications from './integration_tests/mockApis/applications'
-import { stubJourney } from './integration_tests/mockApis/journeyUtils'
+import { stubJourney, verifyApiPost } from './integration_tests/mockApis/journeyUtils'
 import assessments from './integration_tests/mockApis/assessments'
 import users from './integration_tests/mockApis/users'
 import tasks from './integration_tests/mockApis/tasks'
@@ -57,6 +57,7 @@ export default defineConfig({
         ...spaceBookings,
         ...referenceData,
         stubJourney,
+        verifyApiPost,
       })
     },
     baseUrl: 'http://localhost:3007',

diff --git a/integration_tests/mockApis/journeyUtils.ts b/integration_tests/mockApis/journeyUtils.ts
@@ -4,7 +4,7 @@ import {
   ApprovedPremisesAssessment as Assessment,
 } from '@approved-premises/api'
 
-import { bulkStub } from './setup'
+import { bulkStub, getMatchingRequests } from './setup'
 import isAssessment from '../../server/utils/assessments/isAssessment'
 
 export const generateStubsForPage = (
@@ -152,6 +152,15 @@ export const copyCompleteTasksToData = ({ completeTasks, form }) => {
   return data
 }
 
+export const verifyApiPost = async (path: string): Promise<Record<string, unknown>> => {
+  const result = await getMatchingRequests({
+    method: 'POST',
+    url: path,
+  })
+  const { requests } = result.body
+  return JSON.parse(requests[0].body)
+}
+
 export const stubJourney = (form: Application | Assessment): SuperAgentRequest => {
   type JourneyType =
     | { scenarioName: 'assess'; urlPrefix: 'assessment' }

diff --git a/integration_tests/mockApis/spaceBooking.ts b/integration_tests/mockApis/spaceBooking.ts
@@ -107,13 +107,4 @@ export default {
         status: 200,
       },
     }),
-
-  getApiPost: async (path: string): Promise<Record<string, unknown>> => {
-    const result = await getMatchingRequests({
-      method: 'POST',
-      url: path,
-    })
-    const { requests } = result.body
-    return JSON.parse(requests[0].body)
-  },
 }
diff --git a/integration_tests/pages/manage/placements/arrival.ts b/integration_tests/pages/manage/placements/arrival.ts
@@ -26,7 +26,7 @@ export class ArrivalCreatePage extends Page {
 
   checkApiCalled(): void {
     cy.task(
-      'getApiPost',
+      'verifyApiPost',
       apiPaths.premises.placements.arrival({ premisesId: this.placement.premises.id, placementId: this.placement.id }),
     ).then(body => {
       const { arrivalDateTime, expectedDepartureDate } = body as Cas1NewArrival

diff --git a/integration_tests/pages/manage/placements/keyworker.ts b/integration_tests/pages/manage/placements/keyworker.ts
@@ -38,7 +38,7 @@ export class KeyworkerAssignmentPage extends Page {
 
   checkApiCalled(placement: Cas1SpaceBooking): void {
     cy.task(
-      'getApiPost',
+      'verifyApiPost',
       apiPaths.premises.placements.keyworker({ premisesId: placement.premises.id, placementId: placement.id }),
     ).then(body => {
       expect(body).to.deep.equal({ staffCode: this.staffMembers[1].code })

diff --git a/integration_tests/pages/manage/placements/nonArrival.ts b/integration_tests/pages/manage/placements/nonArrival.ts
@@ -47,7 +47,7 @@ export class RecordNonArrivalPage extends Page {
 
   checkApiCalled(placement: Cas1SpaceBooking): void {
     cy.task(
-      'getApiPost',
+      'verifyApiPost',
       apiPaths.premises.placements.nonArrival({ premisesId: placement.premises.id, placementId: placement.id }),
     ).then(body => {
       expect(body).to.deep.equal(this.nonArrivalDetails)

diff --git a/server/testutils/factories/cas1NonArrival.ts b/server/testutils/factories/cas1NonArrival.ts
@@ -6,5 +6,5 @@ import { DateFormats } from '../../utils/dateUtils'
 export default Factory.define<Cas1NonArrival>(() => ({
   reason: faker.string.uuid(),
   notes: faker.lorem.words(20),
-  confirmedAt: DateFormats.dateObjToIsoDateTime(new Date(faker.date.recent())),
+  confirmedAt: DateFormats.dateObjToIsoDateTime(faker.date.recent()),
 }))