-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/deprecate tool #1404
Merged
Merged
Feature/deprecate tool #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljcollinsuk
force-pushed
the
feature/deprecate-tool
branch
4 times, most recently
from
December 16, 2024 09:42
47c71a0
to
e0be495
Compare
Tested locally. Works well. Needs updating to latest main but otherwise LGTM |
michaeljcollinsuk
force-pushed
the
feature/deprecate-tool
branch
from
December 17, 2024 08:57
e0be495
to
a71d288
Compare
jamesstottmoj
previously approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michaeljcollinsuk
force-pushed
the
feature/deprecate-tool
branch
from
December 17, 2024 09:19
a71d288
to
e0be495
Compare
- If a tool is depcrecated, show the deprecation message when it is selected - If a tool is retired, hide it and show a message that user must upgrade
If a deployed release is selected, enable open and restart button. If a undeployed release is selected, enable deploy button only.
Use the value stored in the DB when deploying the tool
Previously all restricted tools were excluded. However, allowing tools to be deprecated means we can update this logic. As some restricted tools may not be deprecated, so should not display an "unsupported" message.
michaeljcollinsuk
force-pushed
the
feature/deprecate-tool
branch
from
December 17, 2024 09:20
e0be495
to
63d646c
Compare
jamesstottmoj
approved these changes
Dec 17, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR relates to ministryofjustice/analytical-platform#6111
It allows AP admins to:
Furthermore, it adds
image_tag
as a field to theTool
model and makes it a required field when creating a new tool release. This helps simplify the code elsewhere when looking up what version of a tool a user has deployed.There are a number of other minor related changes including:
image_tag
anddescription
fields on a Tool release required fields, is no longer necessary.Merging this PR will have the following side-effects:
🔍 What should the reviewer concentrate on?
🧑💻 How should the reviewer test these changes?
📚 Documentation status