Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Python version to 3.12. Bumped dependencies. Removed deprecated test package #1285

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Updated Python version to 3.12. Bumped dependencies. Removed deprecated test package #1285

merged 3 commits into from
Apr 9, 2024

Conversation

jamesstottmoj
Copy link
Contributor

Merging this PR will update the control panel to run on Python 3.12

📝 Summary

This PR resolves

This PR bumps several dependencies and fixes issues in the tests so that the control panel can run against Python 3.12

The changes in this PR are needed because it updates dependencies and core Python version

🔍 What should the reviewer concentrate on?

  • Feedback on specific parts of the code
  • Check side effects, if any

🧑‍💻 How should the reviewer test these changes?

  • Run locally. There should be no noticeable difference between main and this branch

📚 Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

@jamesstottmoj jamesstottmoj marked this pull request as ready for review April 9, 2024 11:11
michaeljcollinsuk
michaeljcollinsuk approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaeljcollinsuk michaeljcollinsuk mentioned this pull request Apr 9, 2024
Closed
3 tasks
@michaeljcollinsuk michaeljcollinsuk merged commit edc2834 into main Apr 9, 2024
5 checks passed
@michaeljcollinsuk michaeljcollinsuk deleted the feature/python-312 branch April 9, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljcollinsuk michaeljcollinsuk michaeljcollinsuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesstottmoj @michaeljcollinsuk