Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPAT-1711 Change the userinfo js for nomis apps #1211

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

ymao2
Copy link
Contributor

@ymao2 ymao2 commented Oct 10, 2023

The PR is to address issue ministryofjustice/analytical-platform#1711

Merging this PR will have the following side-effects:

  • No

πŸ” What should the reviewer concentrate on?

  • The java script

πŸ§‘β€πŸ’» How should the reviewer test these changes?

The following approach only work if you have dev account on hmpps-auth dev server

  • Login the auth0 alpha tenant
  • find a hmpps-auth social connection ( I used bold-case-info-dashboard-dev )
  • click it to see the connection's detail
  • use try connection to test it

πŸ“š Documentation status

  • No changes to the documentation are required
  • This PR includes all relevant documentation
  • Documentation will be added in the future because ... (see issue #...)

Copy link
Contributor

@michaeljcollinsuk michaeljcollinsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Print statement that you might want to remove, otherwise LGTM

@michaeljcollinsuk
Copy link
Contributor

Hmm those CodeQL failures are new?

@ymao2 ymao2 merged commit 8fafe38 into main Nov 7, 2023
4 checks passed
@ymao2 ymao2 deleted the dpat-1711-change-user-profile-for-nomis-login branch November 7, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants