Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs, rails7: nodejs 20.10.0 #1105

Merged
merged 2 commits into from
Dec 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nodejs/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# about minimum2scp/nodejs image

* based on minimum2scp/baseimage (see https://github.com/minimum2scp/dockerfiles/tree/master/baseimage)
* node.js v20.9.0 is installed with [nodenv](https://github.com/nodenv/nodenv)
* node.js v20.10.0 is installed with [nodenv](https://github.com/nodenv/nodenv)
* nodenv is installed in /opt/nodenv
* [yarn](https://yarnpkg.com/) is installed with deb package

Expand Down Expand Up @@ -56,7 +56,7 @@ If you need root privilege, use `sudo bash -lc "..."`.
For example, install LTS version of nodejs:

```
sudo bash -lc "nodenv install 18.18.2"
sudo bash -lc "nodenv install 18.19.0"
```


12 changes: 6 additions & 6 deletions spec/nodejs/00base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,12 @@

describe command('nodenv version-name') do
let(:login_shell){ true }
its(:stdout){ should eq "20.9.0\n" }
its(:stdout){ should eq "20.10.0\n" }
end

[
{
nodejs: '20.9.0',
nodejs: '20.10.0',
},
].each do |v|
describe command('nodenv versions --bare --skip-aliases') do
Expand All @@ -86,15 +86,15 @@
let(:login_shell){ true }
its(:stdout){
should eq <<~ALIASES
20 => 20.9.0
20.9 => 20.9.0
20 => 20.10.0
20.10 => 20.10.0
ALIASES
}
end

{
'20' => '20.9.0',
'20.9' => '20.9.0',
'20' => '20.10.0',
'20.10' => '20.10.0',
}.each do |src, dest|
describe file("/opt/nodenv/versions/#{src}") do
it { should be_symlink }
Expand Down
12 changes: 6 additions & 6 deletions spec/rails7/00base_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -78,12 +78,12 @@

describe command('nodenv version-name') do
let(:login_shell){ true }
its(:stdout){ should eq "20.9.0\n" }
its(:stdout){ should eq "20.10.0\n" }
end

[
{
nodejs: '20.9.0',
nodejs: '20.10.0',
},
].each do |v|
describe command('nodenv versions --bare --skip-aliases') do
Expand All @@ -102,15 +102,15 @@
let(:login_shell){ true }
its(:stdout){
should eq <<~ALIASES
20 => 20.9.0
20.9 => 20.9.0
20 => 20.10.0
20.10 => 20.10.0
ALIASES
}
end

{
'20' => '20.9.0',
'20.9' => '20.9.0',
'20' => '20.10.0',
'20.10' => '20.10.0',
}.each do |src, dest|
describe file("/opt/nodenv/versions/#{src}") do
it { should be_symlink }
Expand Down
Loading