Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map feature #149

Closed
wants to merge 4 commits into from
Closed

Add map feature #149

wants to merge 4 commits into from

Conversation

awoods
Copy link
Contributor

@awoods awoods commented Jul 1, 2022

This feature adds a new option/page in the navbar that displays all items in the collection that have a value in the latitude and longitude columns in the project CSV file. This works out-of-the-box.

This is a port from https://github.com/CollectionBuilder/collectionbuilder-csv.

Related user documentation pull-request: minicomp/wiki#34

For an existing demonstration: https://history.lakecountypubliclibrary.org/cmhc/map/

awoods added a commit to awoods/wiki that referenced this pull request Jul 1, 2022
awoods added a commit to awoods/wiki that referenced this pull request Jul 1, 2022
@bmschmidt
Copy link
Contributor

I'll leave it to @mnyrop and others how this fits into Wax, but a small note on https://github.com/minicomp/wax/pull/149/files#diff-5a448a10ed6933c46c8043cb497427b7536d7d2b103cc32fafecd5d1a0ecbfb1R49-R53: if you want to put in preset layers into a wax site, I would recommend having multiple different corporate sources, not just ESRI--include also some tiles from stamen, OSM, etc.

In an absolutist sense there really ought to be some way to cache tiles locally as with https://openmaptiles.org/. But even failing that, better not to have reliance on just ESRI sets.

@awoods
Copy link
Contributor Author

awoods commented Jul 15, 2022

Thanks, @bmschmidt . It is a good point and a good suggestion to show the pattern for including other map layer sources. I also agree that there is an open question regarding whether this mapping functionality belongs in the scope and goals of Wax. Before working through the details of the former, I will wait on a signal about the latter.

@awoods awoods mentioned this pull request Aug 3, 2023
@awoods awoods closed this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants