Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce redundancy in minetest.registered_nodes lookups #666

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

SmallJoker
Copy link
Member

Less spectacular deduplication. Depending on the Lua internals, this might also improve the performance a bit. The main goal is however to reduce repetitive code, which makes it difficult to spot differences - or bugs for that matter.

How to test:

  1. Sticky piston, connected with regular and vertical wires
  2. Turn the piston (and wires) on and off

Or see whether the tests pass...

@sfan5 sfan5 merged commit 7418d5c into master Dec 27, 2023
4 checks passed
@sfan5 sfan5 deleted the sj_less_table_lookups branch December 27, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants