Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MVPS: don't move non-physical objects #639

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fluxionary
Copy link
Contributor

problem: you can push item entities off the top of the pedestals from Tenplus1's itemframes mod, and then they become immortal ghosts. i see that there's a mesecon.register_mvps_unmov, and registering the entities w/ that would certainly be one solution, but i don't think non-physical things should be getting pushed around in the first place, hence this PR.

@Desour
Copy link
Contributor

Desour commented Apr 18, 2023

It's likely this change will break existing functioning mods. Just take items in itemframes as an example, they should always be moved with the frame.
Also, the code in this PR doesn't even seem to allow to opt-in for non-physical objs.
It's better if individual mods fix this with the provided callback.

@fluxionary
Copy link
Contributor Author

It's likely this change will break existing functioning mods

possibly, but it's also likely to fix "bugs" with other mods.

take items in itemframes as an example, they should always be moved with the frame.

itemframes and pedestals are already registered as MVPS stoppers - they don't want to be moved.

It's better if individual mods fix this with the provided callback.

IMO it's better if mods treat the world and its mechanics as something they need permission to modify, and not dictate that every other mod in the ecosystem has to conform to their intentions. mods that are part of a "game" are one thing - games define behavior - but mods that try to be agnostic about the game and other random mods on the server shouldn't make messes, or should be responsible if they do.

the code in this PR doesn't even seem to allow to opt-in for non-physical objs.

i like this suggestion, i'll implement such a feature if my arguments against the other objections are accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants