Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit piston speed #526

Closed
wants to merge 1 commit into from
Closed

Limit piston speed #526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 34 additions & 5 deletions mesecons_pistons/init.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ local function piston_after_dig(pos, node)
piston_remove_pusher(pos, node, true)
end

local piston_on = function(pos, node)
local function piston_on(pos, node)
local pistonspec = get_pistonspec(node.name, "offname")
if not pistonspec then -- it may be called asynchronously now, don’t crash if something goes wrong
return
end
local dir = vector.multiply(minetest.facedir_to_dir(node.param2), -1)
local pusher_pos = vector.add(pos, dir)
local meta = minetest.get_meta(pos)
Expand All @@ -99,6 +102,9 @@ end

local function piston_off(pos, node)
local pistonspec = get_pistonspec(node.name, "onname")
if not pistonspec then
return
end
minetest.swap_node(pos, {param2 = node.param2, name = pistonspec.offname})
piston_remove_pusher(pos, node, not pistonspec.sticky) -- allow that even in protected area

Expand All @@ -114,6 +120,29 @@ local function piston_off(pos, node)
end
end

-- not on/off as power state may change faster than the piston state
mesecon.queue:add_function("piston_switch", function(pos)
local node = mesecon.get_node_force(pos)
if mesecon.is_powered(pos) then
piston_on(pos, node)
else
piston_off(pos, node)
end
end)

local piston_on_delayed, piston_off_delayed
local delay = mesecon.setting("piston_delay", 0.15)
if delay >= 0 then
local function piston_switch_delayed(pos, node)
mesecon.queue:add_action(pos, "piston_switch", {}, delay, "piston_switch")
end
piston_on_delayed = piston_switch_delayed
piston_off_delayed = piston_switch_delayed
else
piston_on_delayed = piston_on
piston_off_delayed = piston_off
end

local orientations = {
[0] = { 4, 8},
{13, 17},
Expand Down Expand Up @@ -281,7 +310,7 @@ minetest.register_node("mesecons_pistons:piston_normal_off", {
after_place_node = piston_orientate,
sounds = default.node_sound_wood_defaults(),
mesecons = {effector={
action_on = piston_on,
action_on = piston_on_delayed,
rules = piston_get_rules,
}},
on_punch = piston_punch,
Expand Down Expand Up @@ -311,7 +340,7 @@ minetest.register_node("mesecons_pistons:piston_normal_on", {
selection_box = piston_on_box,
sounds = default.node_sound_wood_defaults(),
mesecons = {effector={
action_off = piston_off,
action_off = piston_off_delayed,
rules = piston_get_rules,
}},
on_rotate = piston_rotate_on,
Expand Down Expand Up @@ -360,7 +389,7 @@ minetest.register_node("mesecons_pistons:piston_sticky_off", {
after_place_node = piston_orientate,
sounds = default.node_sound_wood_defaults(),
mesecons = {effector={
action_on = piston_on,
action_on = piston_on_delayed,
rules = piston_get_rules,
}},
on_punch = piston_punch,
Expand Down Expand Up @@ -390,7 +419,7 @@ minetest.register_node("mesecons_pistons:piston_sticky_on", {
selection_box = piston_on_box,
sounds = default.node_sound_wood_defaults(),
mesecons = {effector={
action_off = piston_off,
action_off = piston_off_delayed,
rules = piston_get_rules,
}},
on_rotate = piston_rotate_on,
Expand Down
5 changes: 5 additions & 0 deletions settingtypes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,11 @@ mesecon.movestone_max_pull (Max pull) int 50 1 100
mesecon.piston_max_push (Max push) int 15 1 100
mesecon.piston_max_pull (Max pull) int 15 1 100

# Delay between piston power on/off and actual push/pull.
# Zero means minimal possible delay. Negative value means
# synchronous action (old behavior).
mesecon.piston_delay (Delay) float 0.15 -1 3.0


[mesecons_pressureplates]

Expand Down