Add support for area_pos1 and area_pos2 chatcommands to accept coordinates separated by commas AND spaces #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nates separated by commas AND spaces
SmallJoker
reviewed
Mar 17, 2024
Comment on lines
+50
to
51
| local found, _, x, y, z = param:gsub(", ", ","):find( | ||
| "^(-?%d+)[, ](-?%d+)[, ](-?%d+)$") |
There was a problem hiding this comment.
Suggestion: instead of additional processing, fix the regular expression.
This here works: "^(-?%d+)[, ] *(-?%d+)[, ] *(-?%d+)$"
FYI: The Minetest builtin commands parse it like this: https://github.com/minetest/minetest/blob/master/builtin/game/chat.lua#L584
Those also support relative positions, which however is not a feature we need in this case (player position is too unrealiable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for area_pos1 and area_pos2 chatcommands to accept coordinates separated by commas AND spaces rather than only commas OR spaces. Will also handle combinations of both such as caused by typos (e.g.
/area_pos 1, 2,3)