feat/implement message poll #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PandaGuerrier
requested changes
Oct 29, 2024
| export 'package:mineral/src/domains/events/contracts/server/server_presence_update_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_role_select_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_roles_create_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_roles_remove_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_roles_update_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_stickers_update_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_text_select_event.dart'; | ||
| export 'package:mineral/src/domains/events/contracts/server/server_update_event.dart'; |
There was a problem hiding this comment.
Why remove server update event export ?
| @override | ||
| String? customId; | ||
|
|
||
| FutureOr<void> handle(PrivateMessage message, User user, int answer); |
There was a problem hiding this comment.
Why don't give directly PollAnswer object instead of int ?
| @override | ||
| String? customId; | ||
|
|
||
| FutureOr<void> handle(PrivateMessage message, User user, int answer); |
| @override | ||
| String? customId; | ||
|
|
||
| FutureOr<void> handle(ServerMessage message, Member member, int answer); |
| @override | ||
| String? customId; | ||
|
|
||
| FutureOr<void> handle(ServerMessage message, Member member, int answer); |
| @@ -98,6 +102,10 @@ enum Event implements EnhancedEnum, EventType { | |||
| ['ThreadChannel thread', 'Server server', 'Member member']), | |||
| serverThreadListSync(ServerThreadListSyncEvent, | |||
| ['List<ThreadChannel> threads', 'Server server']), | |||
| serverPollVoteAdd(ServerPollVoteAddEvent, | |||
| ['ServerMessage message', 'Member member', 'String answer']), | |||
There was a problem hiding this comment.
You give as a "String answer", but you give really as int
| @@ -107,6 +107,8 @@ final class Shard implements ShardContract { | |||
| onceEventQueue.add(jsonDecode(message.originalContent)); | |||
| } | |||
|
|
|||
| print(json.encode((message.content as ShardMessage).payload)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.