Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade provider versions #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

upgrade provider versions #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/github-team/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ resource "github_repository" "another_repository" {
}

module "team" {
source = "mineiros-io/team/github"
version = "~> 0.8.0"
source = "../.."

name = "Engineering"
description = "This team is created with terraform to test the terraformn-github-repository module."
Expand All @@ -54,8 +53,7 @@ module "team" {
}

module "child_team" {
source = "mineiros-io/team/github"
version = "~> 0.8.0"
source = "../.."

name = "DevOps"
parent_team_id = module.team.id
Expand Down
6 changes: 2 additions & 4 deletions examples/github-team/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
provider "github" {}

terraform {
required_version = "~> 1.0"
required_version = "~> 1.7"

required_providers {
github = {
source = "integrations/github"
version = "~> 4.0"
version = "~> 6"
}
}
}
4 changes: 2 additions & 2 deletions test/public-repositories-with-team/provider.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
provider "github" {}

terraform {
required_version = "~> 1.0"
required_version = "~> 1.7"

required_providers {
github = {
source = "integrations/github"
version = "~> 5.0"
version = "~> 6"
}
}
}
4 changes: 2 additions & 2 deletions versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
# ---------------------------------------------------------------------------------------------------------------------

terraform {
required_version = "~> 1.0, != 1.1.0, != 1.1.1"
required_version = "~> 1.7"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you changed the requirement to a minimum of Terraform 1.7 here?


required_providers {
github = {
source = "integrations/github"
version = ">= 4.0, < 6.0"
version = "~> 6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise, why does this now require at least version 6 of the provider?

Arguably the correct fix here is to just remove the maximum version constraint as-per the Terraform documentation, i.e. just make it >= 4.0.

}
}
}