Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-attribute-update-settings #72

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

SAOPP
Copy link

@SAOPP SAOPP commented Mar 21, 2023

SAOPP added 4 commits March 19, 2023 22:46
Added 'attributes_require_verification_before_update' parameter
Added `attributes_require_verification_before_update` variable.
Added `user_attribute_update_settings` section description.
@SAOPP SAOPP requested review from mariux and a team as code owners March 21, 2023 06:54
@SAOPP SAOPP mentioned this pull request Mar 22, 2023
SAOPP added 3 commits April 22, 2023 06:41
fix cognito resource for_each meta-argument
@nnsense
Copy link

nnsense commented May 25, 2023

It would be great to have this merged, it's an important feature and it's not really dangerous to merge
@mariux :)

@matteo-ssys
Copy link

Hi, sorry to bother but we had to use this PR source repo in our deployments because we require to set the attributes_require_verification_before_update attribute. This isn't a huge change, and I can assure you (since we've been using it even in prod) that it works, would it be possible to review/merge so that we can use mineiros as a source instead of the PR's repo (which might be deleted at any time)? Thanks! :)

@SAOPP
Copy link
Author

SAOPP commented Jul 11, 2023

Hi, sorry to bother but we had to use this PR source repo in our deployments because we require to set the attributes_require_verification_before_update attribute. This isn't a huge change, and I can assure you (since we've been using it even in prod) that it works, would it be possible to review/merge so that we can use mineiros as a source instead of the PR's repo (which might be deleted at any time)? Thanks! :)

Hello! I assure u that it will not be deleted, because I also use my (this) repository in prod. I still hope for a merge from original authors.

@matteo-ssys
Copy link

Hi Anton, thanks, that's reassuring, also because, judging by the last update to this repo (in 2022) and the silence over the last 4 months, I'm starting to lose hope..

@soerenmartius
Copy link
Member

Hi Guys,

Sorry for the delay. Unfortunately, we can't work on this module anymore as we are working full-time on https://github.com/terramate-io/terramate. We will deffo review all PRs in the future. I just can't commit to a timeline as of now. Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants