Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: A user can mark a task as done #29 #153

Closed
wants to merge 8 commits into from
Closed

PR: A user can mark a task as done #29 #153

wants to merge 8 commits into from

Conversation

vmlb13
Copy link

@vmlb13 vmlb13 commented Oct 20, 2022

PR to fix Issue #29

Created a Kanban Board for the user to have a direct and easy way to change the state of the task

image

  • Used DragDropModule from Angular since Angular Material was already installed in the project
  • Created a updateMethod to change the local state of the Task
  • Added 2 tests, one for the update method in the local-task.service and one for the filter function in the task-list component

Overall I went for this approach to be able to complete the optional acceptance criteria defined in the issue:
"the user can mark a task as done by drag & drop to the list of done tasks
the user can set the task status with more details ("In Progress", "Blocked", ...)"

}

updateTaskState(task: Task): void {
debugger
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whooops ;-)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! :) Removed

@djuerges djuerges closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants