Expect GetContext for context v2 resources
#5025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodor-yanev
previously approved these changes
Nov 22, 2024
JAORMX
force-pushed
the
contextv2-middleware-fix
branch
from
b84e531
to
70a8d19
Compare
teodor-yanev
previously approved these changes
Nov 22, 2024
The getter interfaces for v2-context-only resources was incorrect and it expected us to have a parameter called contextv2. This won't work for our use-cases. This fixes the accessor, thus making the compat middleware work. Signed-off-by: Juan Antonio Osorio <[email protected]>
JAORMX
force-pushed
the
contextv2-middleware-fix
branch
from
70a8d19
to
75eb4ca
Compare
teodor-yanev
approved these changes
Nov 22, 2024
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The getter interfaces for v2-context-only resources was incorrect and it
expected us to have a parameter called contextv2. This won't work for
our use-cases.
This fixes the accessor, thus making the compat middleware work.
Change Type
Mark the type of change your PR introduces:
Testing
Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.
Review Checklist: