Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace printing with tracing #9

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

xandkar
Copy link
Contributor

@xandkar xandkar commented Jul 17, 2024

Fixes #8

@@ -1,6 +1,6 @@
[package]
name = "nom-exif"
version = "1.2.6"
version = "1.3.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I chose to bump minor since this is kind of a new feature, but I don't feel super-strongly about that.

@xandkar
Copy link
Contributor Author

xandkar commented Jul 18, 2024

In case you decide to make tracing an optional feature, I did it in a separate branch:

https://github.com/xandkar/nom-exif/tree/sk/make-tracing-optional

It is probably going to be too annoying to work with at this stage, hence not part of this PR :)

@xandkar
Copy link
Contributor Author

xandkar commented Jul 18, 2024

And there's always the possibility to statically disable tracing levels: https://docs.rs/tracing/latest/tracing/level_filters/index.html#compile-time-filters

Copy link
Owner

@mindeng mindeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great job!

@mindeng mindeng merged commit a03defb into mindeng:main Jul 18, 2024
1 check passed
@mindeng
Copy link
Owner

mindeng commented Jul 18, 2024

I am currently on vacation and may not be able to release a new version for the time being. I will try my best to find an opportunity to release it. Thank you for your brilliant work!

@xandkar xandkar deleted the sk/move-from-eprint-to-tracing branch July 18, 2024 14:07
@xandkar
Copy link
Contributor Author

xandkar commented Jul 18, 2024

Thank you, Min!

@mindeng
Copy link
Owner

mindeng commented Jul 25, 2024

@xandkar Version 1.3.0 has been released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsolicited IO from library code
2 participants