-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace printing with tracing #9
Conversation
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "nom-exif" | |||
version = "1.2.6" | |||
version = "1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I chose to bump minor since this is kind of a new feature, but I don't feel super-strongly about that.
In case you decide to make tracing an optional feature, I did it in a separate branch: https://github.com/xandkar/nom-exif/tree/sk/make-tracing-optional It is probably going to be too annoying to work with at this stage, hence not part of this PR :) |
And there's always the possibility to statically disable tracing levels: https://docs.rs/tracing/latest/tracing/level_filters/index.html#compile-time-filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Great job!
I am currently on vacation and may not be able to release a new version for the time being. I will try my best to find an opportunity to release it. Thank you for your brilliant work! |
Thank you, Min! |
@xandkar Version 1.3.0 has been released! |
Fixes #8