Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for creation of history model on each plugin use #65

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

bsovs
Copy link

@bsovs bsovs commented Apr 8, 2021

  • create DiffHistory class to hold methods
  • plugin creates an instance on DiffHistory each time it is called
  • schema id type is used for the collectionId allowing for custom string ids
  • maintain old model with 'histories' collection default
  • deprecate old use of methods in favour of attaching them to their plugged in schema

docs: update readme for new structure

Brandon Sovran and others added 11 commits April 7, 2021 19:23
* create DiffHistory class to hold methods
* plugin creates an instance on DiffHistory each time it is called
* schema id type is used for the collectionId allowing for custom string ids

BREAKING CHANGE: plugin requires a `name` field due to each model being unique
* maintain old model with 'histories' collection default
* deprecate old use of methods in favour of attaching them to their plugged in schema
@bsovs
Copy link
Author

bsovs commented Apr 8, 2021

I don't know how to fix ci failure. It cannot pull in a repo using git+shh.
This seems to be a common problem with github actions recently.

bsovs added 3 commits April 9, 2021 09:13
* old package was a github repo that has not been merged since the pr two years ago
* new npm package created for it called omit-deep-remove
@bsovs bsovs closed this Apr 9, 2021
@bsovs
Copy link
Author

bsovs commented Apr 9, 2021

Closing for now until ci fixed

@bsovs bsovs reopened this Apr 9, 2021
@bsovs
Copy link
Author

bsovs commented Apr 9, 2021

fixed ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant